Motivation

• Fixes Data Explorer breaks when dataframe cell has complex data in it #36
  • Note upstream changes will be needed in the python package that wraps this to set the schema type to object instead of string.

Changes

• Assuming that the input schema is typed correctly, stringify object columns before displaying them. (Arrays are a subset of objects).
• Made Typescript types a bit stricter to guard against this type of issue in the future: 64f9565

Testing

• Before: https://codesandbox.io/s/pedantic-hodgkin-78o80?file=/src/App.js:216-221, outputs error message. Screenshot
• After: https://codesandbox.io/s/priceless-goldwasser-bdfkn?file=/src/App.js, renders object inside table cell Screenshot

Future steps

• look into setting up unit rendering tests on a per-component basis so errors like this can be detected in a more automated fashion (vs comparing codesandbox before and after) (Update: filed an issue: Testing: Unit tests for individual components #67 )
• Quality of life: we can run pre-commit style hooks on git commit (perhaps use Husky + prettier hooks). (Update: provided in chore: pre-commit hooks for code style and commit message quality #66 )

npm install @nteract/[email protected]
# or 
yarn add @nteract/[email protected]