Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit compiler warning/error if a permission specifies unused method #2680

Open
fyrchik opened this issue Sep 7, 2022 · 1 comment
Open
Labels
compiler Go smart contract compiler enhancement Improving existing functionality I3 Minimal impact S4 Routine U4 Nothing urgent

Comments

@fyrchik
Copy link
Contributor

fyrchik commented Sep 7, 2022

See nspcc-dev/neofs-contract#265
We can do this if all callsites have constant method names. This should cover 99% of our cases.

Depending on the implementation of neo-project/neo#2756, these warnings could become even more important.

@roman-khimov
Copy link
Member

Not sure about this one. When we see a call with clear hash/method combination and can't find a matching permission it's 100% accurate easily detectable error, but it's not the same the other way around. If "all callsites have constant method names" maybe, but even then we have */method permissions that can be too broad in some scenarios.

@roman-khimov roman-khimov added I3 Minimal impact U4 Nothing urgent enhancement Improving existing functionality S4 Routine labels Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler Go smart contract compiler enhancement Improving existing functionality I3 Minimal impact S4 Routine U4 Nothing urgent
Projects
None yet
Development

No branches or pull requests

2 participants