the search_data function raises (unhelpfully) when no results are found

[itcarroll]

results = earthaccess.search_data(
    short_name='SWOT_L2_HR_PIXCVec_2.0',
    temporal=('2023-11-06', '2023-11-07'), 
    point=(0, 0),
)

should return [] but instead raises an IndexError because

earthaccess/earthaccess/search.py

Lines 470 to 472 in bb553e1

	response = get_results(self.session, self, limit)
	cloud = self._is_cloud_hosted(response[0])

assumes response is not empty

If my claim that returning [] is agreeable, then we better also make sure that earthaccess.download doesn't choke when given [].

[chuckwondo]

@itcarroll, I think this is a dup of #526

[mfisher87]

Side thought, perhaps when we return an empty list we should log a warning?