Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change icon: nrk-some-email #284

Open
7 tasks done
stefanogden opened this issue Apr 4, 2024 · 0 comments
Open
7 tasks done

Change icon: nrk-some-email #284

stefanogden opened this issue Apr 4, 2024 · 0 comments
Assignees
Labels
design Discussion and implementation of design. enhancement

Comments

@stefanogden
Copy link

Change icon request

What is the name of the icon?

Make sure the icon fits the naming convention of nrk-category-name-variant--state.

  • icon name is: nrk-some-email
  • icon name is: nrk-some-email-expressive

Do you have an svg icon file?

nrk-some-email.zip

Is the icon file ready to be added to the library?

  • It has fill-rule of fill="currentColor"
  • It has no fill-rules with explicit color values like fill="#f0f0f0"
  • It has been trimmed using a minifier like SVGOMG. (Lowest precision without visual degradation)
  • It has viewbox of viewBox="0 0 24 24" (except logos)
  • It has no explicit width/height

Additional context

NRK.no skal bruke epost-ikonet i alle bylines fremover, og vi ønsker fjerne to streker for å gjøre det mindre busy.

Figma branch:
https://www.figma.com/file/KXGJ6Qcdf8JAyRCoKV55If/branch/FVvPtrJn1ihI3YNsWQyRJ5/NRK-Core-Icons?type=design&node-id=12%3A2&mode=design&t=7XmXMyp2eIuna7Ub-1

image
@stefanogden stefanogden added enhancement design Discussion and implementation of design. labels Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design Discussion and implementation of design. enhancement
Projects
None yet
Development

No branches or pull requests

2 participants