Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web API support #4988

Closed
AndreiMaz opened this issue Aug 21, 2020 · 38 comments
Closed

Web API support #4988

AndreiMaz opened this issue Aug 21, 2020 · 38 comments

Comments

@AndreiMaz
Copy link
Member

Previously our community used one of the most popular API plugin for nopCommerce - https://www.nopcommerce.com/en/api-plugin. But it's a third-party plugin and the nop-templates team decided not to upgrade it to the latest version.

It's one of the most demanded features. That's why we consider implementing the API (by nopCommerce team)

@brian-lagerman
Copy link

brian-lagerman commented Aug 28, 2020

Can you elaborate more on

the nop-templates team decided not to upgrade it to the latest version

I've been following the upgrade path here , and there appears to be activity as of just a few days ago. If you're aware that this plugin is being abandoned, that would be critical information for us.

We're working on our initial version of nopCommerce and the API integration is a must. We've been preparing the site on version 4.2 since the API is supported there, with the hopes of upgrading to 4.3 before our first release. Our planning and timeline are clearly affected by this.

I will say that I feel the API belongs in the core product anyway. The API touches so many parts of the core, that version upgrades understandably take significant time to implement. Anyone using the API plugin is therefore forced to wait a good bit longer on version upgrade adoption.

@naymore
Copy link

naymore commented Sep 2, 2020

Hello there, I am currently searching for an e-commerce solution to integrate in our existing WCM system.
So I'm still in the process of digging through all the documentation and everything... so please correct me if I'm wrong.

Looking at the aforementioned API-plugin I indeed wonder if there is no "built-in/supported" option to integrate nopCommerce into existing WCM deployments on an API-only level ("headless"). I'm just watching the youtube video where that guy praises the architecture in the highest tones. But reading this issue makes me wonder if the "backend" is tightly coupled to the "frontend" which is of course perfectly ok, just not the solution I am looking for.

@AndreiMaz AndreiMaz changed the title API support Web API support Nov 19, 2020
@AndreiMaz AndreiMaz added this to the Version 4.50 milestone Dec 8, 2020
@eadameg
Copy link

eadameg commented Dec 20, 2020

For us it's a deal breaker if the API is not provided ASAP

@luc-cap
Copy link

luc-cap commented Mar 26, 2021

Hi,
the API project is very important.

At the time of Nop3.65, in ROADMAP, there was integration with Orchard, I would like to point out that currently Orchard Core has been rewritten in .NET Core 3.1 and offers 2 plugins ..
The first enables an admin page where you can configure an OpenID Authorization Server.
The second enables an admin page where you can add OpenID Clients ( OpenId Connect Flows enabled ) for authentication.

Have look at this already working , simple solution offered by OrchardCore.

Orchard core in turn was inspired by the Github project: OpenIddict: a versatile solution to implement an OpenID Connect server and token validation in any ASP.NET Core 2.1, 3.1 and 5.0 application.

https://github.com/openiddict/openiddict-core

I hope this info can be useful.

Orchard Core screen-shots:

authentication_client
authentication_server

@ckoch1979silentservice
Copy link

Will it really be released with version 4.5?

@AndreiMaz
Copy link
Member Author

@ckoch1979silentservice Yes. Furthermore, it'll be released for 4.40 as well

@ckoch1979silentservice
Copy link

So it will be a separate module? When will it be released?

@AndreiMaz
Copy link
Member Author

@ckoch1979silentservice Yes, ETA is June

@ckoch1979silentservice
Copy link

Is the code here on Github?

@AndreiMaz
Copy link
Member Author

No

@eadameg
Copy link

eadameg commented Apr 26, 2021

Hi Andrei. Could you give some details of the new API?:

  • Is it just an upgrade of the API developed by Nop-Templates
  • Does it have some improvments?
  • If so, could you please provide highlights?
    Thanks in advance

@AndreiMaz
Copy link
Member Author

@eadameg Hi Eduardo

  1. No, it's a new plugin
  2. Yes, it'll be a much richer plugin
  3. Not yet. We'll share more details later

@martingust
Copy link
Contributor

API-first GraphQL solution would be the dream. Just like the move Saleor Commerce did a few years ago.

“We could have stopped there, but saw brands pressing for more revolutionary front-end experiences,” Mencel says. “Decoupling Saleor’s core from its presentation layer was the obvious path to revolutionary front-ends. As difficult as it was, we tore down what was a rather good open-source e-commerce platform and rebuilt it API-first”.
https://techcrunch.com/2021/03/18/saleor/

@AxelAndersen
Copy link
Contributor

Hi

I read that this new API would come out this June, is that right?
We are moving to NopCommerce with 2 existing webshops, but need to wait for an API to be able to transfer the products.

Best regards,
Axel

@eadameg
Copy link

eadameg commented Jun 15, 2021

I understand the ETA is beginning of July

Hi

I read that this new API would come out this June, is that right?
We are moving to NopCommerce with 2 existing webshops, but need to wait for an API to be able to transfer the products.

Best regards,
Axel

I understand the ETA is beginning of July

@matthewha
Copy link

Hi,

Any chance for an update on timing? Really looking forward to this feature as an official one, although will keep using the excellent work of stepanbenes at https://github.com/stepanbenes/api-for-nopcommerce in the meantime.

Thanks,

Matt

@AndreiMaz
Copy link
Member Author

Just to let you know that we've almost finished the plugin and we plan to release it soon (for version 4.40). The updated ETA is August. This plugin will cover almost all methods of nopCommerce core (backend and frontend). And I also have to announce in advance that this plugin will be available as a paid plugin on our marketplace. Of course, we plan to invest all profit from this plugin into the growth of our team and further development of nopCommerce core. We hope that our community supports us and understands and that the nopCommerce team also has to monetize some small part of all the work we do during all these years.

@brian-lagerman
Copy link

I don’t take issue with the API being a paid plugin, but I could see problems if the API source code isn’t available and extendable. At least in the prior community API plugins we’ve tried, most customizations to nopCommerce Core would require a similar customization to the API. Adding a simple property to Products (say MSRP for example) did require API DTO and mapping changes to reflect the availability of the new property. Maybe you’ve already included support for these types of customizations, I don’t know.

It would just be unfortunate if developers had to choose between extending nopCommerce Core and using the API. Something to consider anyway.

@MaximG1234
Copy link

Yeah, I have to second the above post by @brian-lagerman. I have no problem paying for the plugin (although I think strategically NopCommerce might be making a mistake making people pay for a piece of core functionality) but I will very likely need the ability to extend the API because I expect it will lack features that I need and I cant wait for others to resolve potential bugs.

It would be a deal breaker for me to use the API without the ability to get access to the source code.

@iwhp
Copy link
Contributor

iwhp commented Jul 19, 2021

There is also the problem that if the plugin is not part of the public source code, the logic has to be coded there AND in this Web API. How can that be an advantage? In the long run, this doesn't seem to be a good decision and am I considering about moving to another open source project...

@ActionWebsites
Copy link

Completely agree with the replies here that source code for the paid plugin is an absolute must. If partners/paying developers don't have access to the API source then it is useless and not worth bothering with.

@jakubmaguza
Copy link

How far are you from releasing first version of API? I know you mentioned August, but you think of beginning, or end of August?

@brandon71
Copy link

We are currently looking at moving our platform to NopCommerce. We maintain our own API with our current system due to many third party integrations. Source code access to the API is a must for us. Please let us know if their will be a source code option as soon as possible.

@AndreiMaz
Copy link
Member Author

@jakubmaguza the beginning of August

@AndreiMaz
Copy link
Member Author

@brandon71 Source code will be available

@ActionWebsites
Copy link

@brandon71 Source code will be available

Great news, well done.

@darocker22
Copy link

@AndreiMaz how will the plugin be licensed? Will it be based on a per site or will there be an option to put on unlimited sites? Thanks!!! We are looking forward to being able to use and take advantage of the new API.

@AndreiMaz
Copy link
Member Author

And here we go. The official web API plugin is finally released. Please find it at https://www.nopcommerce.com/web-api

@nopSolutions nopSolutions deleted a comment from P-de-Jong Aug 10, 2021
@ghd258
Copy link

ghd258 commented Aug 11, 2021

收费的

@ahmedzakaria432
Copy link

can i know what is functionalities available in this plugin and can i customize it for my needs ?

@glhays
Copy link

glhays commented Sep 6, 2021 via email

@rahatur
Copy link

rahatur commented Dec 4, 2021

@eadameg Hi Eduardo

  1. No, it's a new plugin
  2. Yes, it'll be a much richer plugin
  3. Not yet. We'll share more details later

Is it going to be a free plugin?

@jehad-alkhateeb-tg
Copy link

Is there any plan to add GraphQL support?

@DmitriyKulagin
Copy link
Contributor

Hi, @jehad-alkhateeb. There are no such plans at the moment.

@ankitbko
Copy link

And here we go. The official web API plugin is finally released. Please find it at https://www.nopcommerce.com/web-api

Its written Web API Plugin is 100% open source. Where is the source code for it and how do I enable it in my local machine?

@xcellenceit
Copy link

Its written Web API Plugin is 100% open source. Where is the source code for it and how do I enable it in my local machine?

It's not the under standard open source license, it has different license, check here https://www.nopcommerce.com/en/web-api-license-terms

What this means is, you will need to pay to get the plugin which is available with full source-code when you buy.

@jakubmaguza
Copy link

I believe wording should be changed. It's not open source, it comes with full source code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests