You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Not even speculating on why that is required for a timer, but I can't seem to find a warning on docs for timer that using it will cause optional=True in @kopf.on.delete to be ignored.
Proposal
Add warning in docs if analysis is correct and this is a requirement for using @kopf.timer. IOW, warn that optional argument to @kopf.on.delete will be overridden.
Code
No response
Additional information
The @kopf.daemon also overrides requirement for finalizer. The docs for it have section https://kopf.readthedocs.io/en/stable/daemons/#deletion-prevention and finalizers are mentioned, although still isn't explicit in saying that optional=True will be ignored in @kopf.on.delete as a result.
The text was updated successfully, but these errors were encountered:
Problem
Using:
with expectation that a finalizer will not be added for kopf operator to resource.
At the same time using
@kopf.timer
on same resource type.Use of
@kopf.timer
overridesoptional=True
in@kopf.on.delete
and makes finalizer mandatory.See
kopf/kopf/on.py
Line 764 in 91e8fd6
Not even speculating on why that is required for a timer, but I can't seem to find a warning on docs for timer that using it will cause
optional=True
in@kopf.on.delete
to be ignored.Proposal
Add warning in docs if analysis is correct and this is a requirement for using
@kopf.timer
. IOW, warn thatoptional
argument to@kopf.on.delete
will be overridden.Code
No response
Additional information
The
@kopf.daemon
also overrides requirement for finalizer. The docs for it have section https://kopf.readthedocs.io/en/stable/daemons/#deletion-prevention and finalizers are mentioned, although still isn't explicit in saying thatoptional=True
will be ignored in@kopf.on.delete
as a result.The text was updated successfully, but these errors were encountered: