Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tie negation to comma-separated list of terms in a sentence #96

Open
DaveJohnson8080 opened this issue Jun 7, 2021 · 2 comments
Open
Assignees

Comments

@DaveJohnson8080
Copy link

Describe the bug
biomedicus.negation.deepen doesn't connect the negation to a comma-based list of terms in a sentence. It only associates the negation with the first listed term.

Example:

"The patient denied a history of hypertension, diabetes, hypercholesterolemia, tobacco use, congestive heart failure, chest pain or syncopal episodes."

In this case it's only tying "patient denied" to "history of hypertension" and not the comma-separated list that follows.

To Reproduce
Run the pipeline including negation.deepen on a document with the above sentence.

Expected behavior
Each comma-separated term in the sentence would be tagged as negated.

Terminal Output
NA

Environment

  • OS:[e.g. Ubuntu 18.04
  • Version: 3.0b9
  • Python Version 3.6.9
  • Java Version OpenJDK 11

Additional context
NA

@benknoll-umn
Copy link
Member

The cause for this could be located in a couple layers, it may be a dependency parsing failure, or it might be a failure for the deepen negation affirmation to associate the trigger with the term via "conj - or" rule. I'll confirm what the cause is and if it's the second part, I may need to write a more robust solution for handling negations in long conjunction chains.

@DaveJohnson8080
Copy link
Author

Discovered a new variation on this one. This sentence....

"the patient is 33 yo with no pmhx, 3-44ppd tobacco, no etoh."

"tobacco" is being negated by the following ", no...".

I checked with this variation as well, and tobacco is not negated.

""the patient is 33 yo with no pmhx, 3-44ppd tobacco."

Confirmed that the issue exists in the latest version. v3.0-rc1
27-Test1.txt
27-Test2.txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants