Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Negation incorrectly being triggered by certain conjunctions #100

Open
benknoll-umn opened this issue Oct 20, 2021 · 0 comments
Open

Negation incorrectly being triggered by certain conjunctions #100

benknoll-umn opened this issue Oct 20, 2021 · 0 comments
Assignees
@benknoll-umn
Labels
bug Something isn't working

Comments

@benknoll-umn
Copy link
Member

Describe the bug
The negation trigger detector includes the full list of Negex negation terms, which includes conjunctions like "but", "however", "although". These terms are included in Negex to use as termination of negated phrases.

To Reproduce
Run on text of attached json document.

Expected behavior
Conjunctions should not be treated as negation terms / triggers.

Terminal Output
See attached json output:
1.txt

Environment

  • OS: Any
  • Version: 3.0 rc 1
  • Python Version: 3.x
  • Java Version: 9+
@benknoll-umn benknoll-umn added bug Something isn't working lang/python labels Oct 20, 2021
@benknoll-umn benknoll-umn self-assigned this Oct 20, 2021
@benknoll-umn benknoll-umn added this to the 3.0 rc3 milestone Mar 9, 2022
@benknoll-umn benknoll-umn modified the milestones: 3.0 rc3, 3.0 rc4 Aug 17, 2022
@benknoll-umn benknoll-umn modified the milestones: 3.0 rc4, 3.0 rc5 Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benknoll-umn benknoll-umn

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@benknoll-umn