Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

augment and integration with tidyroc #13

Open
igordot opened this issue Mar 13, 2019 · 1 comment
Open

augment and integration with tidyroc #13

igordot opened this issue Mar 13, 2019 · 1 comment

Comments

@igordot
Copy link

igordot commented Mar 13, 2019

I am trying to pipe rpart output into the tidyroc package, but it relies on broom::augment().

The example pipe is:

glm(am ~ disp, 
  family = binomial,
  data = mtcars
  ) %>%
  augment() %>%
  make_roc(predictor = .fitted, known_class = am) %>%
  ggplot(aes(x = fpr, y = tpr)) + 
  geom_line()

Since all the tree based tidiers have been moved to broomstick, I tried that. Unfortunately, while broomstick::tidy() works, broomstick::augment() does not.

I was able to manually generate the required data frame, but is there a reason augment() is missing or is it just not ready yet?

@njtierney
Copy link
Owner

Hi @igordot - augment for rpart hasn't been implemented yet - I would be very happy to review a pull request / or other code if you would like to share what you wrote?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants