Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't build v1.1.0 using given instructions #166

Open
herter4171 opened this issue May 3, 2022 · 2 comments
Open

Can't build v1.1.0 using given instructions #166

herter4171 opened this issue May 3, 2022 · 2 comments

Comments

@herter4171
Copy link

Based on the docs, what I've been doing is

git clone --branch v1.1.0 https://github.com/njoy/NJOY21.git
cd NJOY21
# No signature.json, so no metaconfigure.py
mkdir build
cmake ..

This gets me errors like in my screenshot below. I have played this game with v1.6.0 before, so I'm pretty sure I just need a signature.json for v1.1.0. How invasive would it be to include those signatures in the repo tags? That would save us both some leg work.

image

@whaeck
Copy link
Member

whaeck commented May 4, 2022

Normally if you do a "fresh" clone (i.e. from scratch), you should not be seeing these issues. These often pop up due to updates to the dependencies and/or the build system when switching versions and/or branches after having cloned NJOY21.

You may want to try removing the NJOY21 folder and try a fresh clone again. I actually tried the exact same commands as you mentioned and I did not get these issues.

@herter4171
Copy link
Author

I have been following the commands I listed, so I've been using fresh clones. The only thing I botched in my description was a cd build before invoking CMake. As far as the platform, we're on Amazon Linux 2, which uses the Yum package manager. On this platform, I can build v1.0.6 only with a signature.json obtained from a third party, and I can build v1.2.2 as-is. From the CMake output, do you have any idea what it's not happy about for v1.1.0?

Output from CMake:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants