Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing dependency - scikit-image #29

Open
oesteban opened this issue Nov 14, 2022 · 1 comment
Open

Missing dependency - scikit-image #29

oesteban opened this issue Nov 14, 2022 · 1 comment

Comments

@oesteban
Copy link
Contributor

After downloading and installing, the execution of:

python scripts/find_outliers.py data

fails unless skimage is installed (thanks to @effigies for spotting this issue).

Please add the dependency to the pyproject.toml.

Then, I would suggest removing the requirements.txt file, as duplicity in responsibilities is a bad idea (cc @matthew-brett @effigies for insights on whether the presence of a requirements.txt file was suggested by us, or if there's something I'm missing).

@effigies
Copy link

I believe we had suggested a requirements.txt file. It is definitely simple and allows you to do testing if you manage to break your package, but you're right that there is a synchronization cost.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants