Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ObsPlus Dtypes #181

Open
d-chambers opened this issue May 13, 2020 · 0 comments
Open

ObsPlus Dtypes #181

d-chambers opened this issue May 13, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@d-chambers
Copy link
Member

d-chambers commented May 13, 2020

ObsPlus currently implements a few custom datatypes in a bit of a wonky way (in junction with the DataFrameExtractor). Examples of these include 'ops_datetime' which calls a custom function to instantiate an ObsPy.UTCDateTime object, then converts it to a numpy.datetime64[ns]. Although this isn't ideal, it is very useful for wedding UTCDateTime with np.datetime64.

We should look into actually using Pandas' machinery for extending dtypes to remove some of this complexity from ObsPlus. Docs can be found here. We wouldn't need a new dtype per say, but rather a custom constructor so maybe subclassing an existing dtype would do what we need.

@d-chambers d-chambers added the enhancement New feature or request label May 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant