Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatibility with PW3.0.4X #33

Open
eladnova opened this issue Dec 21, 2016 · 8 comments
Open

Incompatibility with PW3.0.4X #33

eladnova opened this issue Dec 21, 2016 · 8 comments

Comments

@eladnova
Copy link

Hi Nico

As per the forums, a few users reporting issues with upgrades to PW3.0.4X
In my case the META tags don't render at all.
I'm using <?php echo $page->seo->render;?>

Any idea when you could look at this?

@gmclelland
Copy link

It worked fine with 3.0.44, but then with 3.0.45 it causes an error.

Tracy Debugger reports the following:
PHP Notice: Trying to get property of non-object in .../wwwroot/site/modules/MarkupSEO/MarkupSEO.module:127

@gmclelland
Copy link

I wonder if it is related to the new changes in Hooks processwire/processwire@953ca72 ?

If I debug that line 127 bd($this->page); show's the page object but doesn't show any seo information attached to it.

@eladnova
Copy link
Author

Hey @gmclelland
I'm not sure. Not too familiar with the inner workings of hooks etc.
Wondering if this is an issue for here or for the PW repo?

@gmclelland
Copy link

Not sure, I'm new to Processwire and hooks as well.

@rolandtoth
Copy link

I think there's a PW core change that is causing this. $this->addHookProperty seems not working in this module anymore.

Changing this line seem to work (only trial and error):

//$this->addHookProperty("Page::seo", $this, 'hookFrontendPage');
$this->wire('page')->addHookProperty("seo", $this, 'hookFrontendPage');

@rolandtoth
Copy link

Fixed 15 minutes ago :)

@gmclelland
Copy link

Good news! Thanks for the heads up @rolandtoth.

@blynx
Copy link

blynx commented Feb 7, 2017

Seems to be fixed in ProcessWire:

https://processwire.com/talk/topic/8007-markupseo-the-all-in-one-seo-solution-for-processwire/?do=findComment&comment=135414

edit:
ah oh - rolandtoth already linked that.
sry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants