From de16a6a30254e4c62315c44884cdb887052832ba Mon Sep 17 00:00:00 2001 From: yujinKim Date: Fri, 10 May 2024 00:44:16 +0900 Subject: [PATCH 1/2] =?UTF-8?q?fix=20:=20=EC=82=AD=EC=A0=9C=ED=95=9C=20?= =?UTF-8?q?=EB=8F=84=EC=84=9C=EB=A1=9C=20=EC=A1=B0=ED=9A=8C=EC=8B=9C=20?= =?UTF-8?q?=EC=A1=B0=ED=9A=8C=20=EB=B6=88=EA=B0=80=EB=8A=A5=ED=95=98?= =?UTF-8?q?=EB=8F=84=EB=A1=9D=20=EC=88=98=EC=A0=95?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../book/repository/impl/BookRepositoryCustomImpl.java | 7 ++++++- .../com/t3t/bookstoreapi/book/service/BookService.java | 5 ----- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/main/java/com/t3t/bookstoreapi/book/repository/impl/BookRepositoryCustomImpl.java b/src/main/java/com/t3t/bookstoreapi/book/repository/impl/BookRepositoryCustomImpl.java index 59aaf365..09166dc4 100644 --- a/src/main/java/com/t3t/bookstoreapi/book/repository/impl/BookRepositoryCustomImpl.java +++ b/src/main/java/com/t3t/bookstoreapi/book/repository/impl/BookRepositoryCustomImpl.java @@ -4,6 +4,7 @@ import com.querydsl.core.types.dsl.BooleanExpression; import com.querydsl.jpa.impl.JPAQueryFactory; import com.t3t.bookstoreapi.book.enums.TableStatus; +import com.t3t.bookstoreapi.book.exception.BookNotFoundException; import com.t3t.bookstoreapi.book.model.dto.CategoryDto; import com.t3t.bookstoreapi.book.model.dto.ParticipantRoleRegistrationDto; import com.t3t.bookstoreapi.book.model.dto.ParticipantRoleRegistrationDtoByBookId; @@ -82,9 +83,13 @@ public BookDetailResponse getBookDetailsById(Long bookId) { book.bookPackage.as("packagingAvailableStatus"))) .from(book) .leftJoin(bookThumbnail).on(book.bookId.eq(bookThumbnail.book.bookId)) - .where(book.bookId.eq(bookId)) + .where(book.bookId.eq(bookId).and(book.isDeleted.eq(TableStatus.FALSE))) .fetchOne(); + if (bookDetailResponse == null) { + throw new BookNotFoundException(); + } + bookDetailResponse.setBookImageUrlList(getBookImageDtoListById(bookId)); bookDetailResponse.setTagList(getBookTagDtoListById(bookId)); bookDetailResponse.setCategoryList(getBookCategoryDtoListById(bookId)); diff --git a/src/main/java/com/t3t/bookstoreapi/book/service/BookService.java b/src/main/java/com/t3t/bookstoreapi/book/service/BookService.java index a4368f27..033594a7 100644 --- a/src/main/java/com/t3t/bookstoreapi/book/service/BookService.java +++ b/src/main/java/com/t3t/bookstoreapi/book/service/BookService.java @@ -79,11 +79,6 @@ public BookDetailResponse getBookDetailsById(Long bookId) { BookDetailResponse bookDetails = bookRepository.getBookDetailsById(bookId); - // 존재하지 않는 도서의 식별자로 조회시 예외 발생 - if(bookDetails == null) { - throw new BookNotFoundForIdException(bookId); - } - bookDetails.setImageUrlPrefix(objectStorageProperties.getStorageUrl()+"/t3team/"); bookDetails.setDiscountedPrice(); bookDetails.setBookStock(); From 20d7de1700265351127557e5f85a3247226dd625 Mon Sep 17 00:00:00 2001 From: yujinKim Date: Fri, 10 May 2024 07:27:32 +0900 Subject: [PATCH 2/2] =?UTF-8?q?feat=20:=20validation=20=EC=B6=94=EA=B0=80?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../t3t/bookstoreapi/book/model/request/BookRegisterRequest.java | 1 + 1 file changed, 1 insertion(+) diff --git a/src/main/java/com/t3t/bookstoreapi/book/model/request/BookRegisterRequest.java b/src/main/java/com/t3t/bookstoreapi/book/model/request/BookRegisterRequest.java index bd56e9ae..e71d7183 100644 --- a/src/main/java/com/t3t/bookstoreapi/book/model/request/BookRegisterRequest.java +++ b/src/main/java/com/t3t/bookstoreapi/book/model/request/BookRegisterRequest.java @@ -67,6 +67,7 @@ public class BookRegisterRequest { private List bookImageList; // 도서 미리보기 이미지 @Size(max = 10, message = "최대 10개의 카테고리를 선택할 수 있습니다.") + @NotEmpty(message = "카테고리를 선택해주세요.") private List categoryList; // 카테고리 id 리스트 @Size(max = 10, message = "최대 10개의 태그를 선택할 수 있습니다.")