Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React Native #3

Open
tomeralmog opened this issue Sep 9, 2016 · 7 comments
Open

React Native #3

tomeralmog opened this issue Sep 9, 2016 · 7 comments

Comments

@tomeralmog
Copy link

Hi,
In my project, I have created a react-native folder in which I cloned https://github.com/mlaval/angular2-react-native-seed and changed the gulpfile to copy the service layer and reuse it for a native app. So far it is working great.

@antonybudianto
Copy link
Member

Hi @tomeralmog , can you open a PR? It'd be a great addition!

@antonybudianto
Copy link
Member

antonybudianto commented Sep 10, 2016

You can open the PR on main starter repo for the usage showcase. If it works well then I'll create a new repo here to host the extension

@tomeralmog
Copy link
Author

Hi Antony,
No problem, in my project I made some assumptions as to where the service folder / naming convention is. In your starter there are no service (please correct me if I am wrong). That is the only thing that is being shared between the two projects. How would you like to proceed from here?
My react-native folder is like another project within your project, with its own npm install, and gulp flow.

@antonybudianto
Copy link
Member

I think you can start a PR to main repo, and I'll separate it as extension after seeing the implementation. @tomeralmog

@antonybudianto
Copy link
Member

Hi @tomeralmog , any updates?
By the way, you may take a look at https://github.com/antonybudianto/angular-webpack-starter

@tomeralmog
Copy link
Author

Sorry I have been swamped here. Will get to it soon!

On Sep 20, 2016, at 5:51 PM, Antony Budianto [email protected] wrote:

Hi @tomeralmog https://github.com/tomeralmog , any updates?
By the way, you may take a look at https://github.com/antonybudianto/angular-webpack-starter https://github.com/antonybudianto/angular-webpack-starter

You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub #3 (comment), or mute the thread https://github.com/notifications/unsubscribe-auth/AD16RCUEk-oOiMAmMev6dd2S86mn83v5ks5qsH-ngaJpZM4J5kiw.

@antonybudianto
Copy link
Member

@tomeralmog Don't worry, take your time 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants