Experimental Angular Adapter

[luii]

Seems like someone is creating a new Angular Adapter based on Angular v16 and Signals.

TanStack/query#6195

[NetanelBasal]

I really don't care. We use this library heavily in production. I'll soon update to v5. Regarding signals, the issue with them is the type guard:

if(result().isSuccess) {
  result().data <=== will still be ? undefined | Data
}

We need to see how we solve it.

[NetanelBasal]

Moreover RxJS is the way to go when dealing with async operations.

[luii]

It sure is.

Do you have something in mind for v5 regarding changing input params and refetching data based upon it. And also parallel/dependent queries with different query keys? Last time i checked i saw mapResultsData which was neither documented nor used by the adapter - so my initial thought was that you might use this for parallel queries. Though correct me if im wrong.

[NetanelBasal]

Yes.

combineLatest[queryOne, queryTwo].pipe(mapResultsData(([one, two]) => {

}))

[luii]

Not gonna lie, i never thought of that to use combineLatest with two queries and im really heavily using this adapter in prod/dev 😆

Maybe we should include this into the Readme (and maybe as an example) to show that its possible, if you want i can work this out later today

[NetanelBasal]

Absolutely. As we continue to utilize this library, we're consistently adding valuable operators. Initially, we implement these operators locally within our code. After some time and validation, we then integrate them into the library itself.

[peterhe2000]

Signal based query requires Angular 16+. That is a show stopper for my team (we are in Angular 14).
If we want to take advantage with Angular query now, ngnat/query adapter is the only choice.
My tech leader comment is we can make a call until npm hit 10k dairly download.

[luii]

@peterhe2000 There isn't that much that got added to tanstack v5 though, a full list of changes you can find here.

I dont see much of a downside sticking to version 1 for the time being, everything that version 2 is capable of, version 1 is also capable of doing right now. In fact, there are some injectables that will be rationalized away, due to the object syntax that tanstack v5 requires you to use. So, i dont see why @ngneat/query in version 2 should be a show stopper in any way, when the only addition is having an unified parameter interface and signal support.

[peterhe2000]

@luii The show stopper i meant is TanStack/query#6195 not ngneat/query. ngneat/query is perfect for us since our application is hugh, we usually upgrade slowly (we wil upgarde to v15 soon since v14 is no longer in LTS support).