Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Access log entries lack newline characters when using JS configuration. #1458

Open
hongzhidao opened this issue Oct 14, 2024 · 0 comments
Open

Comments

@hongzhidao
Copy link
Contributor

When using format in access_log with JS, each log doesn't end with \n.
For example:

{
        "listeners":
                {"*:80":
                        {"pass":"routes"}
                },
        "routes":[
                {"action":{"return":204}}
        ],
        "access_log": {
                "path": "/tmp/access.log",
                "format": "`test`"
        }
}

But it works well with non-JS format option.

hongzhidao added a commit to hongzhidao/unit that referenced this issue Oct 14, 2024
When using JS configuration for the "format" option, access log entries
were being written without newline characters. This commit adds the
missing newline character to each log entry.

Closes: <nginx#1458>
hongzhidao added a commit to hongzhidao/unit that referenced this issue Oct 15, 2024
When using JS configuration for the "format" option, access log entries
were being written without newline characters. This commit adds the
missing newline character to each log entry.

Closes: nginx#1458
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant