Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unitctl: update Cargo.toml metadata #1428

Open
callahad opened this issue Sep 16, 2024 · 9 comments
Open

unitctl: update Cargo.toml metadata #1428

callahad opened this issue Sep 16, 2024 · 9 comments

Comments

@callahad
Copy link
Collaborator

callahad commented Sep 16, 2024

  • It says "UNIT" in a few places
  • Author field should be some collective ("The NGINX Unit Team" instead of Elijah)
@callahad callahad changed the title unitctl: update Cargo.toml metada unitctl: update Cargo.toml metadata Sep 16, 2024
@ac000 ac000 assigned ac000 and unassigned ac000 Sep 16, 2024
@ac000
Copy link
Member

ac000 commented Sep 16, 2024

It says "UNIT" in a few places

This should be part of https://github.com/nginx/unit/commit/f4d3e2ffd51c2aacbdb194affe948af50db46287.patch

@ac000
Copy link
Member

ac000 commented Sep 16, 2024

Cc: @javorszky

@ac000
Copy link
Member

ac000 commented Sep 16, 2024

Author field should be some collective ("The NGINX Unit Team" instead of Elijah)

unit-openapi/Cargo.toml:4:authors = ["[email protected]"]

Who gets that email?

@ac000
Copy link
Member

ac000 commented Sep 16, 2024

Elijah's name appears in a few places

tools/unitctl/man/unitctl.1:20:Elijah Zupancic \fB<[email protected]>\fR
tools/unitctl/unit-client-rs/Cargo.toml:4:authors = ["Elijah Zupancic"]
tools/unitctl/unitctl/Cargo.toml:5:authors = ["Elijah Zupancic"]

I'm a little uneasy just removing his authorship. At the very least I'd want his s-o-b for making this change...

Cc: @dekobon

@dekobon
Copy link

dekobon commented Sep 16, 2024

Please make me the SOB responsible for this. Actually, I don't know what s-o-b is.

Definitely remove me from the man page.
As for Cargo.toml, isn't the custom to add all of the major contributors? Feel free to take me out because I won't be much of a contributor going forward.

@ac000
Copy link
Member

ac000 commented Sep 16, 2024

s-o-b is short for Signed-off-by

@dekobon
Copy link

dekobon commented Sep 16, 2024

Sure, happy to sign off.

@ac000
Copy link
Member

ac000 commented Sep 16, 2024

As for Cargo.toml, isn't the custom to add all of the major contributors?

Yes, happy to do it that way.

@ac000
Copy link
Member

ac000 commented Sep 17, 2024

OK, so I did kind of forget about this but then it is also not clear what to do about the [email protected] email address which appears in a few places

docs/unit-openapi.yaml:33:    email: "[email protected]"
tools/unitctl/unit-openapi/Cargo.toml:4:authors = ["[email protected]"]
tools/unitctl/unit-openapi/README.md:409:[email protected]

This email address goes to Sergey B. Probably not useful... We could use [email protected], the mailing list, but that requires you to be registered with the list.

Then there is what to put in the unitctl man-page, we could just put the same stuff that's in the unit man-page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants