Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow 'lane' in samplesheet.csv to be String type (as in e.g. sarek) #591

Closed
sitems opened this issue Aug 12, 2024 · 4 comments
Closed

Allow 'lane' in samplesheet.csv to be String type (as in e.g. sarek) #591

sitems opened this issue Aug 12, 2024 · 4 comments
Labels
enhancement Improvement for existing functionality

Comments

@sitems
Copy link

sitems commented Aug 12, 2024

Description of feature

Hi, our fastq.gz data provider sequences one sample within multiple lanes and flowcells, and more than one sample can be present in one concrete flowcell+lane combination. For example, for 2 samples (D2077 and M245), pair end files look like this:

D2077_EKDN230048476-1A_H2W7MDSXC_L2_1.fq.gz D2077_EKDN230048476-1A_H2W7MDSXC_L2_2.fq.gz
D2077_EKDN230048476-1A_HFJHGDSX7_L2_1.fq.gz D2077_EKDN230048476-1A_HFJHGDSX7_L2_2.fq.gz
D2077_EKDN230048476-1A_HFTFWDSX7_L4_1.fq.gz D2077_EKDN230048476-1A_HFTFWDSX7_L4_2.fq.gz
D2077_EKDN230048476-1A_HWTLVDSX7_L4_1.fq.gz D2077_EKDN230048476-1A_HWTLVDSX7_L4_2.fq.gz

M245_EKDN230048452-1A_HFJHGDSX7_L2_1.fq.gz MM245_EKDN230048452-1A_HFJHGDSX7_L2_2.fq.gz
MM245_EKDN230048452-1A_HFTFWDSX7_L4_1.fq.gz MM245_EKDN230048452-1A_HFTFWDSX7_L4_2.fq.gz
MM245_EKDN230048452-1A_HWTLVDSX7_L4_1.fq.gz MM245_EKDN230048452-1A_HWTLVDSX7_L4_2.fq.gz

So the same lane number can be present in multiple flowcells (flowcells in my example are H2W7MDSXC,HFJHGDSX7,HFTFWDSX7,HWTLVDSX7). How should I correctly specify the lane column in samplesheet.csv? In sarek, lane can be a string, so in my case, I would for example for the first pair use lane = H2W7MDSXC_L2.

@sitems sitems added the enhancement Improvement for existing functionality label Aug 12, 2024
@ramprasadn
Copy link
Collaborator

Thanks for reporting this @sitems! Sounds like a good idea. I will make a PR on this soon.

@sitems
Copy link
Author

sitems commented Aug 14, 2024

Perfect, by the way, is 'raredisease' using that lane info for read groups as sarek? Because some tools need read group info to work correctly.

@ramprasadn
Copy link
Collaborator

ramprasadn commented Aug 15, 2024

This feature is now integrated into the raredisease project @sitems. Previously, lane information was not utilized for generating read groups, but I've now updated the code to include that functionality as well.

#597

@ramprasadn
Copy link
Collaborator

I am closing this issue for now, but feel free to open it back up if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement for existing functionality
Projects
None yet
Development

No branches or pull requests

2 participants