Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update vcfeval inputs + nf-test conversion #6714

Merged
merged 1 commit into from
Sep 30, 2024
Merged

update vcfeval inputs + nf-test conversion #6714

merged 1 commit into from
Sep 30, 2024

Conversation

nvnieuwk
Copy link
Contributor

The current input for golden truth BED files were incorrectly being used as the analysis BED file. This PR fixes this and adds some documentation to make this more clear

@nvnieuwk nvnieuwk requested a review from a team as a code owner September 30, 2024 13:34
@nvnieuwk nvnieuwk requested review from LeuThrAsp and removed request for a team September 30, 2024 13:34
kubranarci
kubranarci reviewed Sep 30, 2024
View reviewed changes
Copy link
Contributor

@kubranarci kubranarci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only the name of the files have changed?

kubranarci
kubranarci approved these changes Sep 30, 2024
View reviewed changes
Copy link
Contributor

@kubranarci kubranarci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like an appropriate fix! Thank you.

@nvnieuwk
Copy link
Contributor Author

And the truth_bed is now passed to --evaluation-regions and the other way around for the other BED file

@nvnieuwk nvnieuwk added this pull request to the merge queue Sep 30, 2024
Merged via the queue into nf-core:master with commit 83e2df1 Sep 30, 2024
16 checks passed
@nvnieuwk nvnieuwk deleted the fix-rtgtools-vcfeval branch September 30, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kubranarci kubranarci kubranarci approved these changes

@LeuThrAsp LeuThrAsp Awaiting requested review from LeuThrAsp LeuThrAsp was automatically assigned from nf-core/nf-test

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nvnieuwk @kubranarci