-
Notifications
You must be signed in to change notification settings - Fork 695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove tags in tests and tag.yml #6502
Conversation
I think we should keep the tags in the test file. This will make testing in pipelines a lot easier |
Ah ok, yes, if they are needed then we shouldn't default remove them from all the modules |
I think we should revisit the tags in the modules. With the new "only test what's changed" and dependencies in nf-test I'm not sure the amount of tags is necessary. Not sure what to do differently but it's just overkill. Think that's outside the scope of this PR I think removes the yamls is safe. |
Yeah that's mostly fine in modules but it does help in pipelines where you want to test a specific part of your pipeline. The tags are mostly automated by tools anyway so it's no extra work for developers. |
I feel the tags are still useful for doing one off tests while developping, but the So I vote to remove those two and keep just the ones that are specific to that module (e.g. that module, and any upstream modules used during teh testing) |
The only test what's changed is fine for just testing on GHA (I would presume?) Not locally, or? |
I think it's overkill to have tags too, so for all removal |
wait I'm confused, is the purpose of this to have literally 0 tags at all? |
Hi! We have some issues in tools to update the pipeline template so that we don't need tags in modules, see nf-core/tools#2855 and nf-core/tools#2854. To test only one module, you can use the path, so there's no need to use a tag. |
PR checklist
Closes #6001
versions.yml
file.label
nf-core modules test <MODULE> --profile docker
nf-core modules test <MODULE> --profile singularity
nf-core modules test <MODULE> --profile conda
nf-core subworkflows test <SUBWORKFLOW> --profile docker
nf-core subworkflows test <SUBWORKFLOW> --profile singularity
nf-core subworkflows test <SUBWORKFLOW> --profile conda