-
Notifications
You must be signed in to change notification settings - Fork 695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixes sample fastq output bug in cellranger mkfastq #6190
base: master
Are you sure you want to change the base?
Conversation
Hi @julicudini , thank you for this PR. Some checks are not passing, but this is due to the nf-test snapshot of mkfastq not being updated. Could you run |
Would also be good to output the Undetermined in a separate channel, similar to what bcl2fastq/bclconvert do at the moment - that way would behave more consistently :) |
I was working on the PR for the same changes at the same time and missed the notifications on this one. I have already been testing the module on my PR with a new version of demultiplex that handles these changes, so it would make things simpler for me if we can merge this one #6194. And @julicudini you can address the changes for the other cellranger modules on this PR |
@julicudini , are you still working on this? |
I think this was fixed in #6194 already |
Fair point, lets wait for @julicudini |
PR checklist
Closes #6189
versions.yml
file.label
nf-core modules test <MODULE> --profile docker
nf-core modules test <MODULE> --profile singularity
nf-core modules test <MODULE> --profile conda
nf-core subworkflows test <SUBWORKFLOW> --profile docker
nf-core subworkflows test <SUBWORKFLOW> --profile singularity
nf-core subworkflows test <SUBWORKFLOW> --profile conda