-
Notifications
You must be signed in to change notification settings - Fork 695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nf-test for FASTQ_ALIGN_HISAT2 #4887
Merged
adamrtalbot
merged 15 commits into
nf-core:master
from
adamrtalbot:nf-test-to_fastq_align_hisat2
Feb 29, 2024
Merged
nf-test for FASTQ_ALIGN_HISAT2 #4887
adamrtalbot
merged 15 commits into
nf-core:master
from
adamrtalbot:nf-test-to_fastq_align_hisat2
Feb 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxulysse
reviewed
Feb 12, 2024
maxulysse
approved these changes
Feb 12, 2024
maxulysse
reviewed
Feb 12, 2024
maxulysse
approved these changes
Feb 12, 2024
snapshots might need updating |
Main issue was we were trying to snapshot unstable bams, so just not snapshoting them |
jch-13
pushed a commit
to jch-13/modules
that referenced
this pull request
Mar 19, 2024
* nf-test for FASTQ_ALIGN_HISAT2 * nf-test for FASTQ_ALIGN_HISAT2 single-end * Apply suggestions from code review * update snapshots * update snapshot * do not snapshot bam * do not snapshot bam --------- Co-authored-by: Maxime U Garcia <[email protected]> Co-authored-by: Maxime U Garcia <[email protected]>
jennylsmith
pushed a commit
to RSC-RP/modules
that referenced
this pull request
Mar 20, 2024
* nf-test for FASTQ_ALIGN_HISAT2 * nf-test for FASTQ_ALIGN_HISAT2 single-end * Apply suggestions from code review * update snapshots * update snapshot * do not snapshot bam * do not snapshot bam --------- Co-authored-by: Maxime U Garcia <[email protected]> Co-authored-by: Maxime U Garcia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
Closes #XXX
versions.yml
file.label
PROFILE=docker pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
PROFILE=singularity pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
PROFILE=conda pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware