Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made GSEA butterfly plot optional #4872

Merged
merged 3 commits into from
Feb 7, 2024
Merged

Made GSEA butterfly plot optional #4872

merged 3 commits into from
Feb 7, 2024

Conversation

WackerO
Copy link
Contributor

@WackerO WackerO commented Feb 7, 2024

See nf-core/differentialabundance#143

PR checklist

Closes #XXX

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • PROFILE=docker pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
    • PROFILE=singularity pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
    • PROFILE=conda pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware

Copy link
Member

@pinin4fjords pinin4fjords left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, we'll just have to go fix the GSEA module for linting. Also, don't forget the Changelog.

@WackerO
Copy link
Contributor Author

WackerO commented Feb 7, 2024

@pinin4fjords Linting fixed! But I'm pretty sure modules still doesn't have a changelog. Unless it was added recently and I cannot find the file?

Copy link
Member

@pinin4fjords pinin4fjords left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I'm an idiot, carry on :-)

@WackerO
Copy link
Contributor Author

WackerO commented Feb 7, 2024

No no, that mistake has happened to me as well 😄

@WackerO WackerO added this pull request to the merge queue Feb 7, 2024
Merged via the queue into nf-core:master with commit 7aa7ced Feb 7, 2024
11 checks passed
@WackerO WackerO deleted the gsea_fix branch February 7, 2024 14:36
jch-13 pushed a commit to jch-13/modules that referenced this pull request Mar 19, 2024
* Made GSEA butterfly plot optional

* Fixed meta.yml
jennylsmith pushed a commit to RSC-RP/modules that referenced this pull request Mar 20, 2024
* Made GSEA butterfly plot optional

* Fixed meta.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants