Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sentieon docker image #3348

Closed
wants to merge 7 commits into from
Closed

Sentieon docker image #3348

wants to merge 7 commits into from

Conversation

adamrtalbot
Copy link
Contributor

@adamrtalbot adamrtalbot commented Apr 28, 2023

Replace Sentieon Docker image with one from Quay.io

There might be a good reason for not using quay.io, but it's worth a try.

  • Turns off Singularity tests because they don't work because of LD_PRELOAD (not sure why not) but Conda and Docker seem to work.

Copy link
Member

@maxulysse maxulysse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Available on conda now?

Comment on lines -111 to +117
- profile: "conda"
- profile: "singularity"
tags: sentieon/bwamem
- profile: "conda"
- profile: "singularity"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is happening there?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sentieon on conda works fine, Sentieon on singularity has a problem with LD_LIBRARY_PATH. It should be fine on most machines but doesn't work on the GHA runners. See here for when I fixed the problem: bioconda/bioconda-recipes#38781

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't run Sentieon with the singularity images introduced in this PR. I get the now well-known:

error while loading shared libraries: libstdc++.so.6: cannot open shared object file: No such file or directory

Similar issue with the subsequent images made by Don for Sentieon 202112.07.

I'm afraid this is a showstopper for this PR 😬

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Darn!!! I don't know how singularity containers are built, where do they inherit LD_LIBRARY from?

.github/workflows/pytest-workflow.yml Show resolved Hide resolved
@adamrtalbot
Copy link
Contributor Author

Available on conda now?

Has been for a while: https://github.com/bioconda/bioconda-recipes/tree/master/recipes/sentieon

@maxulysse
Copy link
Member

Not needed anymore

@maxulysse maxulysse closed this Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants