Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renamed nodes that are out of viewport keep renaming state #47438

Closed
susnux opened this issue Aug 22, 2024 · 5 comments · Fixed by #48425
Closed

Renamed nodes that are out of viewport keep renaming state #47438

susnux opened this issue Aug 22, 2024 · 5 comments · Fixed by #48425
Assignees
@susnux
Labels
2. developing Work in progress 29-feedback bug feature: files

Comments

@susnux
Copy link
Contributor

susnux commented Aug 22, 2024 •
edited
Loading

Just tried 29.0.5 and the bug is only partially fixed :

  • If you rename a file and the new name sends the file at the bottom of the list, not visible on screen, then the folder stays in edit mode and you need to reload the page.

Originally posted by @Mer0me in #42813 (comment)

  1. Have a list with nodes 1 to 50
  2. Rename 1 to 51, so it is moved to the very bottom.
  3. Scroll down to it
  4. See that rename state is still active
@susnux susnux added bug 1. to develop Accepted and waiting to be taken care of feature: files labels Aug 22, 2024
@susnux susnux self-assigned this Aug 22, 2024
@susnux susnux added 2. developing Work in progress and removed 1. to develop Accepted and waiting to be taken care of labels Aug 23, 2024
@Mer0me

This comment was marked as off-topic.

Sign in to view
@susnux

This comment was marked as resolved.

Sign in to view
@susnux susnux mentioned this issue Sep 27, 2024
Merged
4 tasks
@Mer0me
Copy link

Mer0me commented Oct 18, 2024

Is it supposed to be fixed on 30.0.1 ? It's not...

@susnux
Copy link
Contributor Author

susnux commented Oct 18, 2024

No as you can see the backport is not yet merged, so earliest is 30.0.2.
Track progress in: #48731

@susnux
Copy link
Contributor Author

susnux commented Oct 18, 2024

This is was fixed and backports are expected to be merged in November maintenance releases (30.0.2 and 29.0.9).
If you experience a similar issue after updating to one of those issues, please open a new issue.
For general discussion please use: https://help.nextcloud.com/

@nextcloud nextcloud locked as resolved and limited conversation to collaborators Oct 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@susnux susnux

Labels
2. developing Work in progress 29-feedback bug feature: files
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(files): Ensure renaming state is correctly reset nextcloud/server
3 participants
@susnux @Mer0me @szaimen