Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Store user which has downloaded file in activity feed #46305

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Koc
Copy link
Contributor

@Koc Koc commented Jul 4, 2024

Summary

I've added information about user which downloaded file via public link (if this user was logged in)

image

Checklist

@Koc Koc force-pushed the feature/improve-file-download-activity-logging branch 2 times, most recently from e60846f to bdbd494 Compare July 4, 2024 16:58
@kesselb kesselb added enhancement 3. to review Waiting for reviews labels Jul 4, 2024
@kesselb kesselb added this to the Nextcloud 30 milestone Jul 4, 2024
@Koc
Copy link
Contributor Author

Koc commented Jul 5, 2024

@kesselb can you run pipeline for PR?

@Koc
Copy link
Contributor Author

Koc commented Jul 5, 2024

mates, seems like some test failures are unrelated to my changes. How can we fix them?

@kesselb
Copy link
Contributor

kesselb commented Jul 5, 2024

Ignore performance and cypress for now.

@Koc Koc force-pushed the feature/improve-file-download-activity-logging branch from bdbd494 to d9c33af Compare July 9, 2024 22:56
@szaimen szaimen removed their request for review July 10, 2024 09:31
@Koc
Copy link
Contributor Author

Koc commented Jul 10, 2024

@kesselb all green 🟢, except performance and cypress

@artonge artonge force-pushed the feature/improve-file-download-activity-logging branch from d9c33af to 6e9b00f Compare July 11, 2024 07:17
@artonge
Copy link
Contributor

artonge commented Jul 11, 2024

Rebased

@Koc
Copy link
Contributor Author

Koc commented Jul 15, 2024

@artonge so, let's merge then?

@artonge
Copy link
Contributor

artonge commented Jul 15, 2024

@Koc sure, I created a local copy of your PR here: #46533
This is to have the result of all the CI steps.

Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

@susnux susnux force-pushed the feature/improve-file-download-activity-logging branch from 6e9b00f to 287fb2d Compare July 26, 2024 14:24
This was referenced Jul 30, 2024
@Altahrim Altahrim mentioned this pull request Aug 5, 2024
@skjnldsv skjnldsv modified the milestones: Nextcloud 30, Nextcloud 31 Aug 6, 2024
@skjnldsv
Copy link
Member

skjnldsv commented Aug 6, 2024

Tests were successful in #46533
Can be merged for 31

@Koc
Copy link
Contributor Author

Koc commented Aug 6, 2024

sad that we can't include it into 30 😿

@skjnldsv
Copy link
Member

skjnldsv commented Aug 7, 2024

To be fair, I think this also requires some discussion. Because we have no display on the public sharing pages, to tell the user they are logged in, I think this creates a fake feeling of privacy. You might want to open a link and not be tracked as an existing user.

@Koc
Copy link
Contributor Author

Koc commented Aug 20, 2024

@skjnldsv to be honest I don't see any problem here because functionality named "Shared link" and not "Anonymous link". Also I can add some kind of warning message for logged in users that we will store his username during download. WDYT?

image
image

@sorbaugh
Copy link
Contributor

sorbaugh commented Sep 26, 2024

@Koc does this also work with internal links?

@Koc Koc force-pushed the feature/improve-file-download-activity-logging branch from 287fb2d to b8a9d1f Compare September 27, 2024 23:15
@Koc
Copy link
Contributor Author

Koc commented Sep 27, 2024

@sorbaugh good question. No, in this case there are no any activity stored at all. Url looks like http://localhost/remote.php/dav/files/user/308986224.jpg and it seems like we're not entering into ShareController at all.

Maybe we can store activity by modifying \OCA\DAV\Connector\Sabre\FilesPlugin::httpGet in separate PR, WDYT?

BTW I've rebased PR but there are still conflicts in the ShareControllerTest 😕

@kesselb
Copy link
Contributor

kesselb commented Sep 28, 2024

@Koc conflicts 😨

@Koc Koc force-pushed the feature/improve-file-download-activity-logging branch from b8a9d1f to 4b1a335 Compare September 28, 2024 21:07
@Koc
Copy link
Contributor Author

Koc commented Sep 28, 2024

@kesselb I know 😃
image

Fixed, BTW

@Koc Koc force-pushed the feature/improve-file-download-activity-logging branch from 4b1a335 to 1d9fff1 Compare September 28, 2024 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 📄 To do (~10 entries)
Development

Successfully merging this pull request may close these issues.

5 participants