From 55dd692cd9ec061c31796f8280e3daf264aaa12c Mon Sep 17 00:00:00 2001 From: Ferdinand Thiessen Date: Tue, 20 Aug 2024 19:42:11 +0200 Subject: [PATCH] fix: Adjust more places for logical position Signed-off-by: Ferdinand Thiessen --- apps/dashboard/src/DashboardApp.vue | 5 ++-- apps/dav/src/components/AvailabilityForm.vue | 4 +-- apps/dav/src/views/CalDavSettings.vue | 4 +-- .../src/components/PersonalSettings.vue | 2 +- .../files/src/components/FilesListVirtual.vue | 30 +++++++++---------- apps/files/src/views/ReferenceFileWidget.vue | 2 +- .../src/actions/sharingStatusAction.scss | 2 +- .../src/components/NewFileRequestDialog.vue | 2 +- .../src/components/SharingEntry.vue | 2 +- .../src/components/SharingEntryInherited.vue | 2 +- .../src/components/SharingEntryLink.vue | 2 +- .../src/components/SharingEntrySimple.vue | 2 +- .../src/views/SharingDetailsTab.vue | 10 +++---- apps/oauth2/src/components/OAuthItem.vue | 2 +- apps/settings/src/components/AppList.vue | 4 +-- .../src/components/AppList/AppItem.vue | 12 ++++---- .../AppStoreDiscover/CarouselType.vue | 4 +-- .../components/AppStoreDiscover/PostType.vue | 4 +-- .../src/components/AuthTokenSetup.vue | 4 +-- .../src/components/AuthTokenSetupDialogue.vue | 2 +- .../DeclarativeSection.vue | 4 +-- apps/settings/src/components/Encryption.vue | 2 +- apps/settings/src/components/Markdown.vue | 6 ++-- .../src/components/Users/shared/styles.scss | 2 +- .../ui-multiselect/src/jquery.multiselect.js | 2 +- .../src/components/SetStatusModal.vue | 2 +- apps/weather_status/src/App.vue | 2 +- apps/workflowengine/src/components/Check.vue | 2 +- apps/workflowengine/src/components/Rule.vue | 8 ++--- core/css/apps.scss | 14 ++++----- core/css/tooltip.scss | 24 +++++++-------- core/src/components/AppMenuEntry.vue | 4 +-- core/src/components/ContactsMenu/Contact.vue | 5 +--- .../UnifiedSearchLocalSearchBar.vue | 2 +- core/src/components/setup/RecommendedApps.vue | 2 +- core/src/views/LegacyUnifiedSearch.vue | 8 ++--- core/src/views/Profile.vue | 2 +- 37 files changed, 92 insertions(+), 100 deletions(-) diff --git a/apps/dashboard/src/DashboardApp.vue b/apps/dashboard/src/DashboardApp.vue index b4c761d5bc7b4..4571a130d9f9d 100644 --- a/apps/dashboard/src/DashboardApp.vue +++ b/apps/dashboard/src/DashboardApp.vue @@ -569,11 +569,10 @@ export default { background-size: 32px; width: 32px; height: 32px; - margin-inline-end: 16px; background-position: center; float: left; - margin-top: -6px; - margin-left: 6px; + margin-top: -6px 0; + margin-inline-start: 6px 16px; } img { diff --git a/apps/dav/src/components/AvailabilityForm.vue b/apps/dav/src/components/AvailabilityForm.vue index fd7ede24ea667..f3a7570325f14 100644 --- a/apps/dav/src/components/AvailabilityForm.vue +++ b/apps/dav/src/components/AvailabilityForm.vue @@ -202,12 +202,12 @@ export default { } .to-text { - padding-right: 12px; + padding-inline-end: 12px; } .empty-content { color: var(--color-text-lighter); - margin-top: 4px; + margin-block-start: var(--default-grid-baseline); align-self: center; } diff --git a/apps/dav/src/views/CalDavSettings.vue b/apps/dav/src/views/CalDavSettings.vue index c55767dc6affb..b93986a91373c 100644 --- a/apps/dav/src/views/CalDavSettings.vue +++ b/apps/dav/src/views/CalDavSettings.vue @@ -150,10 +150,10 @@ export default { diff --git a/apps/settings/src/components/AppList.vue b/apps/settings/src/components/AppList.vue index 68df4072ee802..2372b461f5785 100644 --- a/apps/settings/src/components/AppList.vue +++ b/apps/settings/src/components/AppList.vue @@ -326,14 +326,14 @@ $toolbar-height: 44px + $toolbar-padding * 2; } #app-list-update-all { - margin-left: 10px; + margin-inline-start: 10px; } &__toolbar { height: $toolbar-height; padding: $toolbar-padding; // Leave room for app-navigation-toggle - padding-left: $toolbar-height; + padding-inline-start: $toolbar-height; width: 100%; background-color: var(--color-main-background); position: sticky; diff --git a/apps/settings/src/components/AppList/AppItem.vue b/apps/settings/src/components/AppList/AppItem.vue index 881be612445b8..e6ba776b06dbe 100644 --- a/apps/settings/src/components/AppList/AppItem.vue +++ b/apps/settings/src/components/AppList/AppItem.vue @@ -257,8 +257,8 @@ export default { .app-name--link::after { content: ''; position: absolute; - left: 0; - right: 0; + inset-inline-start: 0; + inset-inline-end: 0; height: var(--app-item-height); } @@ -271,7 +271,7 @@ export default { .icon-loading-small { display: inline-block; top: 4px; - margin-right: 10px; + margin-inline-end: 10px; } } @@ -317,10 +317,8 @@ export default { .app-name--link::after { content: ''; position: absolute; - top: 0; - left: 0; - right: 0; - bottom: 0; + inset-block: 0; + inset-inline: 0; } .app-actions { diff --git a/apps/settings/src/components/AppStoreDiscover/CarouselType.vue b/apps/settings/src/components/AppStoreDiscover/CarouselType.vue index 537c3004c0e5c..e657c7ae8005c 100644 --- a/apps/settings/src/components/AppStoreDiscover/CarouselType.vue +++ b/apps/settings/src/components/AppStoreDiscover/CarouselType.vue @@ -165,10 +165,10 @@ h3 { // See padding of discover section &--next { - right: -54px; + inset-inline-end: -54px; } &--previous { - left: -54px; + inset-inline-start: -54px; } } diff --git a/apps/settings/src/components/AppStoreDiscover/PostType.vue b/apps/settings/src/components/AppStoreDiscover/PostType.vue index 536609f329f73..512ce9875105a 100644 --- a/apps/settings/src/components/AppStoreDiscover/PostType.vue +++ b/apps/settings/src/components/AppStoreDiscover/PostType.vue @@ -255,12 +255,12 @@ export default defineComponent({ &-wrapper { position: relative; top: -50%; - left: -50%; + inset-inline-start: -50%; } position: absolute; top: -46px; // half of the icon height - right: -46px; // half of the icon width + inset-inline-end: -46px; // half of the icon width } } diff --git a/apps/settings/src/components/AuthTokenSetup.vue b/apps/settings/src/components/AuthTokenSetup.vue index dcff95afd6343..74dd3c2bbed2d 100644 --- a/apps/settings/src/components/AuthTokenSetup.vue +++ b/apps/settings/src/components/AuthTokenSetup.vue @@ -81,8 +81,8 @@ export default defineComponent({ diff --git a/core/src/components/UnifiedSearch/UnifiedSearchLocalSearchBar.vue b/core/src/components/UnifiedSearch/UnifiedSearchLocalSearchBar.vue index d68466ea91ae2..a273e87875896 100644 --- a/core/src/components/UnifiedSearch/UnifiedSearchLocalSearchBar.vue +++ b/core/src/components/UnifiedSearch/UnifiedSearchLocalSearchBar.vue @@ -160,7 +160,7 @@ function clearAndCloseSearch() { inset-inline: 0; } // Hide all other entries, especially the user menu as it might leak pixels - :global(.header-right:has(.local-unified-search--open) > :not(.unified-search-menu)) { + :global(.header-end:has(.local-unified-search--open) > :not(.unified-search-menu)) { display: none; } } diff --git a/core/src/components/setup/RecommendedApps.vue b/core/src/components/setup/RecommendedApps.vue index b8d213ed5593b..9bab568a924e0 100644 --- a/core/src/components/setup/RecommendedApps.vue +++ b/core/src/components/setup/RecommendedApps.vue @@ -255,7 +255,7 @@ p { } .checkbox-radio-switch { - margin-left: auto; + margin-inline-start: auto; padding: 0 2px; } } diff --git a/core/src/views/LegacyUnifiedSearch.vue b/core/src/views/LegacyUnifiedSearch.vue index 265475212bc01..63bf70d6002de 100644 --- a/core/src/views/LegacyUnifiedSearch.vue +++ b/core/src/views/LegacyUnifiedSearch.vue @@ -762,8 +762,8 @@ $input-padding: 10px; // Loading spinner &::after { - right: $input-padding; - left: auto; + inset-inline-end: $input-padding; + inset-inline-start: auto; } &-input, @@ -796,7 +796,7 @@ $input-padding: 10px; &-reset, &-submit { position: absolute; top: 0; - right: 4px; + inset-inline-end: 4px; width: $input-height - $input-padding; height: $input-height - $input-padding; min-height: 30px; @@ -814,7 +814,7 @@ $input-padding: 10px; } &-submit { - right: 28px; + inset-inline-end: 28px; } } diff --git a/core/src/views/Profile.vue b/core/src/views/Profile.vue index ff9c7957b9023..a513e0caf78a3 100644 --- a/core/src/views/Profile.vue +++ b/core/src/views/Profile.vue @@ -329,7 +329,7 @@ $content-max-width: 640px; } .avatardiv__user-status { - right: 14px; + inset-inline-end: 14px; bottom: 14px; width: 34px; height: 34px;