data loss: named versions are lost from group folder after a while

[sena73]

"Versions" extension is not working properly with the "Group folder" extension in NC 29.

If I create named versions of a file in a group folder, they are created, but disappear after a while (noticed after days).

Old versions simply disappear in a group folder without any notice or log message. I would tell it is a severe bug, as I do not see a way to recover deleted versions.

I understand that it gonna take time to fix. But please, make at least this 2 extensions conflicting, so people will not be able to install both of them simultaneously. Or better make "Versions" menu disabled for the files in "Group folder".

I found other bugs that indicate problems when both extensions are working:

#2965 #2343

[joshtrichards]

If I create named versions of a file in a group folder, they are created, but disappear after a while (noticed after days).

You may be correct. I suspect we're expiring labeled (named) versions within GF. Offhand I don't see the GF Versions handler checking for labeled versions in the same way that the non-GF versions does:

https://github.com/nextcloud/server/blob/2480567005776cc96d543b52992c83a41d75d1a6/apps/files_versions/lib/Storage.php#L569-L570

This may have been lost during the #2543 -> #2857 jump though offhand I don't see it in the former either.

Cc: @artonge

[artonge]

@joshtrichards is right, we do have the check for "normal" versions, but I missed to implement it for groupfolders' versions.

[joshtrichards]

Thanks for reporting this, @sena73. Will be fixed in the next release!