Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have a virtual group "all" for the advanced permissions #2779

Open
schiessle opened this issue Jan 23, 2024 · 4 comments
Open

Have a virtual group "all" for the advanced permissions #2779

schiessle opened this issue Jan 23, 2024 · 4 comments
Labels
1. to develop Issues that are ready for development enhancement feature: acl Items related to the groupfolders ACL or "Advanced Permissions"

Comments

@schiessle
Copy link
Member

schiessle commented Jan 23, 2024

When using group folders it happens to me regularly I want to remove from everyone the write permissions, e.g. that they can't accidentally break my documents.

What I'm doing at the moment:

  1. I remove for every group with access to the group folder the "write" and "delete" permissions
  2. I add for myself all permissions again

This has some obvious shortcomings:

  1. If the admin give later additional groups access to the folder they are not covered and can edit my documents
  2. If a lot of groups have access to the folder it is quite some work to remove the rights from each group

Proposed solution:

The "advanced permissions" drop-down has a virtual group called "all users". This way I can modify the access rights for everyone with one click.

@schiessle schiessle added enhancement 0. Needs triage Issues that need to be triaged labels Jan 23, 2024
@anoymouserver
Copy link

I've never used it, but you might find the apps Everyone Group or Auto Groups useful as an alternative.

@Jerome-Herbinet Jerome-Herbinet added the feature: acl Items related to the groupfolders ACL or "Advanced Permissions" label Aug 21, 2024
@provokateurin
Copy link
Member

@schiessle can you elaborate on shortcoming 1? I don't really understand the problem.
As for 2 we could improve the way you can change permissions, e.g. bulk changing by clicking on a column or shift-drag selection.

@provokateurin provokateurin added 1. to develop Issues that are ready for development and removed 0. Needs triage Issues that need to be triaged labels Sep 17, 2024
@schiessle
Copy link
Member Author

@provokateurin Thanks for looking into the issue!

The shortcoming is simple. You have a large instance, many users and groups. You have a shared group folder, let's say a company wide folder for all company related files. Now you want to allow only a single person or group access to a subfolder. At the moment. You have to do the following:

  1. Deny all groups access to the subfolder which also means that you need to know all groups with access to the group folder. This is already a impossible assumption, but if you know all groups this can be already a huge list of advanced permissions you have to create one by one
  2. Than you have to grant the specific group/persons access rights again
  3. Whenever a new group is introduced after you configured the advanced permissions they will have access to the subfolder. You and everyone else who manages advanced permissions would always need to remember all folders they configured this way, get to know that a new group was introduced and adjust the advanced permissions, hopefully really fast so that people don't get access to files they shouldn't access -> error prone and simply not possible.

This would be solved if the advanced permissions would know a virtual group "all users", where In can set the permissions for all users without knowing anything about user and group structure on the system and without having to worry that something changes to the user/group structure.

I hope this makes it clear.

@provokateurin
Copy link
Member

Ok I understand now, but I don't know if this is something we can fix this way.
We will need to take a closer look later when we actually try to implement this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Issues that are ready for development enhancement feature: acl Items related to the groupfolders ACL or "Advanced Permissions"
Projects
None yet
Development

No branches or pull requests

4 participants