[Bug]: stable-3.12 builds are not working (how to reproduce release builds?)

[cluck]

⚠️ Before submitting, please verify the following: ⚠️

• This is a bug, not a question or a configuration issue.
• This issue is not already reported on Github (I've searched it).
• Nextcloud Server and Desktop Client are up to date. See Server Maintenance and Release Schedule and Desktop Releases for supported versions.
• I agree to follow Nextcloud's Code of Conduct

Bug description

A am looking to rebuild nextcloud.exe with some code changes as a drop-in replacement file for the Windows Nextcloud 3.12.x Client as installed from https://github.com/nextcloud-releases/desktop/releases, that is, keeping all external dependencies like Qt5 unchanged. Given that the many dependencies are intimidating, I was hoping to leverage an existing CI to create a test build.

I am using Github Actions in a fork, which does work in principle, but fails specifically on the stable-3.12 branch: both macOS and Windows fail with build system bugs.

Given that the branch is still actively receiving backports, I wonder if you intend to maintain them in a working condition?

Anyway, my personal motivation for reporting this is to find any working CI to obtain a patched release binary to validate fixes for #7166 in the field without investing a day or three building my own build environment.

1. macOS Build and Test / macOS Build and Test (pull_request) fails:

CMake Error: The source directory "/Users/runner/work/nextcloud-desktop/nextcloud-desktop/downloads/git/dev-utils/kshimgen" does not exist.

1. Windows Build and Test / Windows Build and Test (pull_request) fails in step Install Craft Master with Nextcloud Client Deps:

2024-09-30T15:38:16.3830780Z          		 "-o" "D:\_\43a0f8a1\Python-3.11.7\Python\deepfreeze\deepfreeze.c"
2024-09-30T15:38:17.7853592Z          Traceback (most recent call last):
2024-09-30T15:38:17.7867472Z            File "D:\_\43a0f8a1\Python-3.11.7\Tools\scripts\deepfreeze.py", line 460, in <module>
2024-09-30T15:38:17.7868191Z              def generate(args: list[str], output: TextIO) -> None:
2024-09-30T15:38:17.7953987Z          TypeError: 'type' object is not subscriptable

Steps to reproduce

One way is probably for a maintainer to re-run the GitHub Actions.

Another way:

1. Fork nextcloud/desktop to a personal account
2. Checkout stable-3.12
3. Branch to stable-3.12-test and commit some insignificant change
4. Maybe remove most of the .github/workflows except Windows and macOS related
5. Create pull request from stable-3.12-test into stable-3.12
6. Watch the CI steps fail after some 30min-50min

Expected behavior

CI jobs would pass.

Which files are affected by this bug

/other

Operating system

Windows

Which version of the operating system you are running.

Windows 10

Package

Other

Nextcloud Server version

29.0.6

Nextcloud Desktop Client version

3.12.7

Is this bug present after an update or on a fresh install?

Fresh desktop client install

Are you using the Nextcloud Server Encryption module?

Encryption is Disabled

Are you using an external user-backend?

• Default internal user-backend
• LDAP/ Active Directory
• SSO - SAML
• Other

Nextcloud Server logs

No additional info

Additional info

No additional info

[mgallien]

@cluck may I ask why you are trying to build 3.12 branch ?
You have probably noticed that at least regarding build macOS and windows github actions are building fine in other stable branches

[cluck]

I am tracking all 3.12, 3.13 and 3.14 branches here: https://github.com/cluck/nextcloud-desktop/pulls

3.12.7 is the most recent release on Windows which we have tested toroughly, which there are no reports of it crashing and we're not aware of the UI being broken. We have a large fleet and are evaluating updates carefully.

Btw. the 3.13 branch also fails to build.