Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix composer config and unit tests #839

Closed
wants to merge 3 commits into from

Conversation

HanXHX
Copy link

@HanXHX HanXHX commented Mar 2, 2023

  • Do not add vendor dir in versionning
  • Fix autoloading dev
  • Add ext-xml dep
  • Remove hard dependency to PHP 7.2
  • Add PHPUnit dev dep and fix legacy unit tests

@skjnldsv
Copy link
Contributor

skjnldsv commented Mar 2, 2023

- Do not add vendor dir in versionning
- Fix autoloading dev
- Add ext-xml dep
- Remove hard dependency to PHP 7.2
- Add PHPUnit dev dep and fix legacy unit tests

Signed-off-by: Emilien Mantel <[email protected]>
@skjnldsv skjnldsv requested a review from blizzz March 7, 2023 08:24
Copy link
Contributor

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove hard dependency to PHP 7.2

Production still runs it, so blocking for now.

@HanXHX
Copy link
Author

HanXHX commented Jul 10, 2023

Remove hard dependency to PHP 7.2

Production still runs it, so blocking for now.

Did you read the code? => https://github.com/nextcloud-releases/updater_server/pull/839/files#diff-d2ab9925cad7eac58e0ff4cc0d251a937ecf49e4b6bf57f8b95aab76648a9d34L7

With my patch, composer can run on "all" PHP version.

@nickvergessen
Copy link
Contributor

With my patch, composer can run on "all" PHP version.

But anyone updating a dependency might bump it to a version that is not compatible with 7.2 anymore.

@HanXHX
Copy link
Author

HanXHX commented Jul 11, 2023

Please, can you confirm:

@nickvergessen
Copy link
Contributor

  • This project must be run only on PHP 7.2 (eol 2020)?
  • No plan to support up to date PHP version?

That is not what the platform is about. Please see this documentation page: https://getcomposer.org/doc/06-config.md#platform
Platform specifies a minimum, not an "only version".

  • Is this project supposed to run properly with Nextcloud server with up to date PHP version?

This project here runs totally independent and is actually only run by us, not by admins running a Nextcloud Server 26 or whatever other version at home.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants