-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix composer config and unit tests #839
Conversation
HanXHX
commented
Mar 2, 2023
- Do not add vendor dir in versionning
- Fix autoloading dev
- Add ext-xml dep
- Remove hard dependency to PHP 7.2
- Add PHPUnit dev dep and fix legacy unit tests
Please sign the DCO :) |
- Do not add vendor dir in versionning - Fix autoloading dev - Add ext-xml dep - Remove hard dependency to PHP 7.2 - Add PHPUnit dev dep and fix legacy unit tests Signed-off-by: Emilien Mantel <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove hard dependency to PHP 7.2
Production still runs it, so blocking for now.
Did you read the code? => https://github.com/nextcloud-releases/updater_server/pull/839/files#diff-d2ab9925cad7eac58e0ff4cc0d251a937ecf49e4b6bf57f8b95aab76648a9d34L7 With my patch, composer can run on "all" PHP version. |
But anyone updating a dependency might bump it to a version that is not compatible with 7.2 anymore. |
Please, can you confirm:
|
That is not what the platform is about. Please see this documentation page: https://getcomposer.org/doc/06-config.md#platform
This project here runs totally independent and is actually only run by us, not by admins running a Nextcloud Server 26 or whatever other version at home. |