-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for SCRAM-SHA-256 authentication #67
Comments
My bad I didn't mean to close got a little trigger happy :) |
Hi @ngalantowicz , this really looks interesting i have tagged this issue to be prioritized by our PM. |
Hi, We are currently using the We have talked a couple times about migrating to the official mongo driver, and this could be something to weight in for that. Are you aware if the official driver supports SCRAM? |
@gsanchezgavier and @roobre thanks for taking an interest in this feature. The official mongo driver does support SCRAM https://github.com/mongodb/mongo-go-driver/blob/master/mongo/options/clientoptions.go#L45-#L46 |
@ngalantowicz Thanks for the confirmation! We'll add this to the list of things to track for the migration :) |
Same applies for SCRAM-SHA-1 blocked by #71 |
@ all: I wish you a Happy New Year 2022! Any news about it? Linked to: |
Incidentally, I'm working on a fork which essentially removes globalsign/mgo in favour of the mongodb official driver here : https://github.com/pyrotechnics-io/nri-mongodb/tree/hbaste-scramsha256. This would at least in theory allow it to be used for SCRAM-SHA-256 as well as MongoDB 5 (has undergone some very basic testing against 4.4 with SCRAM-SHA-256). The approach followed is to mimick the interface of mgo as used in the code with a facade wrapper and then eventually refactor and do away with the wrapper altogether. A lot of the test code had deep hooks into mgo objects unfortunately so had to temporarily disable several of them. Disclaimer: Its still a pre-alpha wip but any help testing it is much appreciated. |
Hi The new MongoDB OHI has been released in public preview, this version will be GA during June. Some of the new features provided:
For more information check the following resources. Because it is based on Prometheus the metric names are different from our legacy OHI, check our migration guide if you need more details. |
Work has been completed on this issue. |
Is your feature request related to a problem? Please describe.
Integration fails due to no mongo 4+ SCRAM-SHA-256 authentication support. I've found that the driver you all use has yet to enable support for SCRAM-SHA-256 authentication as well. There's an existing pr (stale - 2+ years old) in the driver repo you all use. I understand that this will need to be done first in order to enable here, so I'm curious and asking if the mgo feature is completed would you all be willing to support it.
Feature Description
Enable mongo 4+ SCRAM-SHA-256 authentication mechanism
Describe Alternatives
n/a
Additional context
Existing mgo pr seeking support for completion
Priority
Blocker
The text was updated successfully, but these errors were encountered: