Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deduplicate llgramarea from RXD. #3053

Open
1uc opened this issue Aug 21, 2024 · 0 comments
Open

Deduplicate llgramarea from RXD. #3053

1uc opened this issue Aug 21, 2024 · 0 comments

Comments

@1uc
Copy link
Collaborator

1uc commented Aug 21, 2024

There two copies of llgramarea:
https://github.com/search?q=repo%3Aneuronsimulator%2Fnrn%20llgramarea&type=code

This causes issues with Cython, because it's dlsym'ed, but also available via Cython. The latest version of Cython uses name manging when generting C++ sources, i.e. we can't use dlsym easily. When turning off namemanging, we get issues with escaping the quotes properly on MinGW, i.e. we need to define a variable CYTHON_EXTERN_C='extern "C"' at some point while passing down the variable through Python code and MinGW shell we end up with the equivalent of:

#define CYTHON_EXTERN_C extern C

Note that none of the code related to CYTHON_EXTERN_C is under our control, it's all handled for us by Cython.

@1uc 1uc changed the title Deduplicate llgramarea form RXD. Deduplicate llgramarea from RXD. Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant