Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete issue branch if workflow fails #108

Open
hvgazula opened this issue Nov 15, 2023 · 7 comments
Open

Delete issue branch if workflow fails #108

hvgazula opened this issue Nov 15, 2023 · 7 comments
Assignees

Comments

@hvgazula
Copy link
Contributor

hvgazula commented Nov 15, 2023

Currently, the issue branch is retained in the remote repo and, (ideally) we want this branch to be deleted if the testing workflow fails. However, the key stumbling block is moving deletion into a separate job. For more info, see #104 (comment)

@hvgazula
Copy link
Contributor Author

Edward, do you think can look into this?

@hvgazula hvgazula changed the title Delete issue branch of workflow fails Delete issue branch if workflow fails Nov 15, 2023
@gaiborjosue
Copy link
Contributor

Hello @hvgazula to make sure I understand this, do you want to delete the branch created in the repo if either singularity or docker fails?

@hvgazula
Copy link
Contributor Author

as the title suggests...if the workflow fails..

@gaiborjosue
Copy link
Contributor

Okay 👍Would you agree to perform this on the already existing 'failed' job?

@hvgazula
Copy link
Contributor Author

before that I want you to look at my workflow and tell what can fail...if it has any loopholes that I did not address but you did in yours.

@gaiborjosue
Copy link
Contributor

Sure, I am creating comments on your PR

@gaiborjosue
Copy link
Contributor

Hello @hvgazula, deleting the branch if fails is implemented: https://github.com/neuronets/trained-models/blob/hvgazula/issue104/.github/workflows/new_model.yml#L334

I tested it out and it worked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants