Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix(modelData): Fix the get model data workflow #106

Open
gaiborjosue opened this issue Nov 10, 2023 · 2 comments · May be fixed by #107
Open

Fix(modelData): Fix the get model data workflow #106

gaiborjosue opened this issue Nov 10, 2023 · 2 comments · May be fixed by #107
Assignees
@gaiborjosue
Labels
bug Something isn't working

Comments

@gaiborjosue
Copy link
Contributor

As of now, the workflow: https://github.com/neuronets/trained-models/blob/master/.github/workflows/get_model_data.js fails due to reformating of current directory distribution and standard model cards and specs.
@gaiborjosue gaiborjosue self-assigned this Nov 10, 2023
@gaiborjosue gaiborjosue added the bug Something isn't working label Nov 10, 2023
@gaiborjosue gaiborjosue linked a pull request Nov 15, 2023 that will close this issue
Draft
@gaiborjosue gaiborjosue linked a pull request Nov 15, 2023 that will close this issue
fix(get_model_data): Parse model_card instead of spec #107
Draft
@gaiborjosue
Copy link
Contributor Author

Hello @hvgazula, the workflow is now updated and working, a quick demo can be found on my fork's website: https://gaiborjosue.github.io/trained-models-fork/

Now, before merging the PR I just created, model_card.yaml needs to be added to all models. I will start working on that and will reach out in case I need a better insight into models.

@hvgazula
Copy link
Contributor

We want this to be triggered as soon as an issue branch germinating out of model addition is merged into the main (via a PR).

@gaiborjosue gaiborjosue mentioned this issue Nov 17, 2023
Closed
@gaiborjosue gaiborjosue mentioned this issue Nov 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gaiborjosue gaiborjosue

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(get_model_data): Parse model_card instead of spec neuronets/trained-models
2 participants
@hvgazula @gaiborjosue