FIX remove extra conditional statement in decision tree

[PSSF23]

Reference Issues/PRs

What does this implement/fix? Explain your changes.

Any other comments?

[github-actions]

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

_{Generated for commit: 47f0320. Link to the linter CI: here}

[adam2392]

Oh I see. This is used in UnsupervisedTree https://docs.neurodata.io/scikit-tree/dev/generated/sktree.tree.UnsupervisedDecisionTree.html

[PSSF23]

Oh I see. This is used in UnsupervisedTree https://docs.neurodata.io/scikit-tree/dev/generated/sktree.tree.UnsupervisedDecisionTree.html

OK, the documentation says differently, so I didn't see it.

[adam2392]

Oh I see. This is used in UnsupervisedTree https://docs.neurodata.io/scikit-tree/dev/generated/sktree.tree.UnsupervisedDecisionTree.html

OK, the documentation says differently, so I didn't see it.

Ah I see. Feel free to update the PR to fix the documentation then.

[PSSF23]

@adam2392 why is min_samples_split calculation repeated in super()._fit and _build_tree? Shouldn't the local class handle it sufficiently?

[adam2392]

@adam2392 why is min_samples_split calculation repeated in super()._fit and _build_tree? Shouldn't the local class handle it sufficiently?

Oh yeah I think in unsupervised tree, that can be removed then since we rely on the fork's check.

I think that was there because I tried adding it into the downstream unsup class, but it felt hacky to me.

[PSSF23]

I'll open another PR if other problems are found.