Module images

[ciroiriarte]

Would it be ok to contribute module images?. I'm working with network cards for PowerEdge servers.

[danner26]

Hey @ciroiriarte images currently are only for devices, not for modules. Network cards for servers are technically modules so these would not be included

[ciroiriarte]

Hello!, There is a feature to add an image to the module type, would you consider accepting them in a separate folder/directory as contribution?. It really helps for local inspection and planning when who design/plans is different from who implements. We're happily using it. Regards, CI._

…

On Tue, May 16, 2023, 09:44 Daniel W. Anner ***@***.***> wrote: Hey @ciroiriarte <https://github.com/ciroiriarte> images currently are only for devices, not for modules. Network cards for servers are technically modules so these would not be included — Reply to this email directly, view it on GitHub <#1344 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AANLJ5AWODEIX2PAVVO544TXGOHDHANCNFSM6AAAAAAYAY655Y> . You are receiving this because you were mentioned.Message ID: <netbox-community/devicetype-library/repo-discussions/1344/comments/5917469 @github.com>

[danner26]

Hey @ciroiriarte, as long as the functionality is added in the upstream NetBox repository then we would be happy to adapt

[ciroiriarte]

Hey!, Today (v3.3.0), it's possible to add module type images. That's all, adding reference images for whoever is working in the DC.

I'm still struggling with my first PR though, hope to find some time this week to fix it.

[danner26]

Hey @ciroiriarte I have added the ability to add module images now. If you sync your fork with the upstream master, you will now see a module-images folder. Images should have the same name as the device type and should preferably be in png format