Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Remove leading and tailing whitespace in LinkInput #3859

Open
markusguenther opened this issue Sep 26, 2024 · 4 comments
Open

BUG: Remove leading and tailing whitespace in LinkInput #3859

markusguenther opened this issue Sep 26, 2024 · 4 comments
Labels
8.3 Bug Label to mark the change as bugfix

Comments

@markusguenther
Copy link
Member

Description

Editors often had the case that they copied links from an Excel list and then pasted them into e.g. LinkEditor fields.

If the people do not notice that a space at the end of the URL was copied or a tab at the beginning, the link immediately leads to a 404. 

Steps to Reproduce

link-trim.mp4

Expected behavior

The links is trimmed so that we do not save the leading or tailing whitespace.

Affected Versions

Neos: 8.3 (but guess it happens also in earlier versions)

UI: 8.3

@markusguenther markusguenther added Bug Label to mark the change as bugfix 8.3 labels Sep 26, 2024
markusguenther added a commit to markusguenther/neos-ui that referenced this issue Sep 26, 2024
Whitespaces like a tab can lead to a 404 error if a URL has been pasted to a LinkEditor or LinkInput.

As datasources, assets, URLs and slugs should not start with a whitespace, we can remove them.

Fixes: neos#3859
@Jai-Marothiya
Copy link

Hello @markusguenther,

I am interested in solving this bug and I believed I can fix it. Please assign this issue to me.

@markusguenther
Copy link
Member Author

Thank you for taking on this issue. However, we already have an open pull request for this. You are welcome to review it.

@Jai-Marothiya
Copy link

Cool, can you assign me 1-2 relevant issues similar to this or may be different on which I can work?

@Jai-Marothiya
Copy link

I reviewed your PR and it looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.3 Bug Label to mark the change as bugfix
Projects
None yet
Development

No branches or pull requests

2 participants