Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deployment account default if deploy-signer not specified? #187

Open
devhawk opened this issue May 9, 2023 · 1 comment
Open

deployment account default if deploy-signer not specified? #187

devhawk opened this issue May 9, 2023 · 1 comment

Comments

@devhawk
Copy link
Contributor

devhawk commented May 9, 2023

the neo debugger ensures the current version of contract under debug (i.e. the .nef path specified in the program prop of the launch config) is deployed to the debugger stub chain. If it find a different version of the contract (matches by name) then it deploys an update (similar to if the contract exposed a method that invokes ContractManagement.Update). If it finds no name match, the debugger deploys the contract.

If the contract has to be deployed or updated, the deploy-signer property is used to sign that contract. If deploy-signer is not specified, the null address (all zeros UInt160) is used as the signer for the contract deployment or update.

Is this the right fallback? SHould we default to using the signer instead?

@devhawk devhawk changed the title Deploy Signer incorrectly parsed deployment account default if deploy-signer not specified? May 9, 2023
@ixje
Copy link

ixje commented May 10, 2023

Is this the right fallback? Should we default to using the signer instead?

Option 1 is to make deploy-signer mandatory such that you're always aware of what is used. Perhaps with "@zero" as special support in case you don't care.

Option 2 is to log a big fat warning somewhere that you're likely to check if things are not working as intended.

Option 3 falling back to signer at first sight also doesn't sound bad. I have to think about this one a bit more though

The main problem atm for me is that it assigns some default signer silently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants