Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor comments fix in hbb_tutorials, chapters 6 & 7 #1026

Open
michalkornek opened this issue Apr 29, 2020 · 0 comments
Open

Minor comments fix in hbb_tutorials, chapters 6 & 7 #1026

michalkornek opened this issue Apr 29, 2020 · 0 comments

Comments

@michalkornek
Copy link

michalkornek commented Apr 29, 2020

In the file learn.py in hbb_tutorials, chapter 6, there are 2 errors/typos in the comments:

  1. # communication channel in this case) and starts tracking the post population.

If I understand well, the comment in line 27 it should be:
"(...) and starts tracking the pre population."

  1. #function to inhibit the error population after 25 seconds

Based on the code on lines 83-84 and on the observed simulation, the comment in line 82 it should be:
"(...) the error population after 15 seconds"

Not so sure about this one, but in all files in chapter 7, there is probably a typo in the comments in each of the examples, below is just a link to the first one:
3.

#Creating the BG and Thalamus components that confirm to the specified rules

I am not a native English speaker, but I believe it should be "conform" instead?

Versions

  • OS: Windows 10
  • Browser: chrome
  • Nengo GUI: 0.4.6
  • Other: Nengo core v3.1.0
@michalkornek michalkornek changed the title Minor comment fix in hbb_tutorials, chapter 6, learn.py Minor comments fix in hbb_tutorials, chapter 6, learn.py Apr 29, 2020
@michalkornek michalkornek changed the title Minor comments fix in hbb_tutorials, chapter 6, learn.py Minor comments fix in hbb_tutorials, chapters 6 & 7 Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant