Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add moved block to account for terraform changes on AWS only #2673

Merged
merged 2 commits into from
Sep 2, 2024
Merged

add moved block to account for terraform changes on AWS only #2673

merged 2 commits into from
Sep 2, 2024

Conversation

Adam-D-Lewis
Copy link
Member

@Adam-D-Lewis Adam-D-Lewis commented Aug 30, 2024 •
edited
Loading

Reference Issues or PRs

Fixes #2669
Similar to #2639

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally? Tested on AWS
  • Did you add new tests?

How to test this PR?

Any other comments?

@Adam-D-Lewis Adam-D-Lewis changed the title fix AWS issue add moved block to account for terraform changes on AWS only Aug 30, 2024
@dcmcand dcmcand merged commit f2c3076 into develop Sep 2, 2024
28 checks passed
@dcmcand dcmcand deleted the aws_moved_block_fix branch September 2, 2024 07:20
@Adam-D-Lewis Adam-D-Lewis mentioned this pull request Sep 3, 2024
Open
@Adam-D-Lewis Adam-D-Lewis added the project: JATIC Work item needed for the JATIC project label Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenafoster kenafoster kenafoster approved these changes

@aktech aktech Awaiting requested review from aktech

@marcelovilla marcelovilla Awaiting requested review from marcelovilla

Assignees
No one assigned
Labels
project: JATIC Work item needed for the JATIC project
Projects
🪴 Nebari Project Management
Status: Done 💪🏾
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] - Deploying Latest 'develop' branch destroys all JupyterLab home directories
3 participants
@Adam-D-Lewis @kenafoster @dcmcand