-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add amazon_web_services configuration option to specify EKS cluster api server endpoint access setting #2618
Merged
viniciusdc
merged 14 commits into
nebari-dev:develop
from
MetroStar:eks-private-endpoint
Sep 9, 2024
Merged
Changes from 4 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
501438d
Add option in nebari-config (amazon_web_services.eks_endpoint_access)…
joneszc 1a52244
Merge branch 'nebari-dev:develop' into eks-private-endpoint
joneszc 215f3c1
Add option in nebari-config (amazon_web_services.eks_endpoint_access)…
joneszc 5376681
Merge branch 'nebari-dev:develop' into eks-private-endpoint
joneszc 90e8687
Merge branch 'nebari-dev:develop' into eks-private-endpoint
joneszc 7f0874a
reformat __init__.py single quotes
joneszc 598aea1
Merge branch 'nebari-dev:develop' into eks-private-endpoint
joneszc 521711f
Edit validation for amazon_web_services.eks_endpoint_access var optio…
joneszc ed57b0e
Merge branch 'nebari-dev:develop' into eks-private-endpoint
joneszc dbe30ab
Edit validation for amazon_web_services.eks_endpoint_access var optio…
joneszc 4887d3d
Merge branch 'nebari-dev:develop' into eks-private-endpoint
joneszc 09e745f
Merge branch 'nebari-dev:develop' into eks-private-endpoint
joneszc d7d569d
Merge branch 'nebari-dev:develop' into eks-private-endpoint
joneszc aea94fa
Merge branch 'nebari-dev:develop' into eks-private-endpoint
joneszc File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This validator could be removed if you switch to an enum with a default value
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dcmcand
Removed validator per your suggestion; using
typing.Literal
, in lieu of pydantic enums, for congruency with pending PR#2668's invocation of Literal