Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRAN Release 0.1.0 #16

Closed
5 tasks done
brownag opened this issue Feb 14, 2021 · 5 comments
Closed
5 tasks done

CRAN Release 0.1.0 #16

brownag opened this issue Feb 14, 2021 · 5 comments

Comments

@brownag
Copy link
Member

brownag commented Feb 14, 2021

I want to submit this package for a first CRAN release ASAP.

@brownag brownag changed the title CRAN Release 0.0.1 CRAN Release 0.1.0 Feb 18, 2021
@dylanbeaudette
Copy link
Member

Thanks. Do we need to fully solve #15/#5 before a CRAN submission? I'd like to make sure that most cases are resolved, but a general solution is likely going to take some time / planning.

@brownag
Copy link
Member Author

brownag commented Feb 18, 2021

No, I don't think we need to "solve" them completely. But I personally have spent very little time with the explainST code aside from my verification that it runs on all subgroups.

I essentially want to look closer at the ones that I know are problematic, and figure out why. I am not sure about the extent of the problems at this point... my feeling is it is actually not that much work.

Sure refining definitions could go on forever, but getting known missing entries in the table and ensuring that all multi-word subgroups at least populate with "?" for missing entries shouldn't be too hard, right?

@dylanbeaudette
Copy link
Member

No, I don't think we need to "solve" them completely. But I personally have spent very little time with the explainST code aside from my verification that it runs on all subgroups.

I essentially want to look closer at the ones that I know are problematic, and figure out why. I am not sure about the extent of the problems at this point... my feeling is it is actually not that much work.

Sure refining definitions could go on forever, but getting known missing entries in the table and ensuring that all multi-word subgroups at least populate with "?" for missing entries shouldn't be too hard, right?

Works for me. Maybe we can divide / conquer.

@brownag
Copy link
Member Author

brownag commented Feb 18, 2021

We are in pretty good shape now! With a couple recent additions to explainST tests, we are now at 95% coverage package-wide.

@brownag brownag closed this as completed Mar 1, 2021
@brownag
Copy link
Member Author

brownag commented Mar 1, 2021

We are on CRAN as of 2021-02-25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants