Editor Stuck in Infinite Loop

[nikhilcharles-ncc]

Hi! I was editing a flow using :bbpb.edit request-body, but I noticed that if an invalid edit is saved, the editor (vim in my case) is reopened without an explanation. Even after closing the editor multiple times, the editor is reopened unless the invalid change is reverted.

When I reverted the change, the log showed the following error message: Error: [14:20:43.902] Error while editing typedef: Encountered error encoding message: Field '2' not found in typedef or does not have type attribute..

I did some digging in the code and It looks like this is the spot where the infinite loop happens:

blackboxprotobuf/mitmproxy/bbpb.py

Lines 153 to 166 in 3ca6a14

	while True:
	last_data = message_json
	edited_output = ctx.master.spawn_editor(edited_output)
	if edited_output == last_data:
	# No changes to the message, just cancel
	return
	try:
	protobuf_data = blackboxprotobuf.protobuf_from_json(
	edited_output, typedef_out
	)
	break
	except Exception as ex:
	logging.error(f"Error while editing typedef: {ex}")

Perhaps a fix could be to break the loop when an exception occurs or to present the error to the user before respawning the editor.