From e860f812493b7efd097ebb59dcb478e1c45dd11f Mon Sep 17 00:00:00 2001 From: James Douglass Date: Tue, 28 May 2024 11:24:30 -0700 Subject: [PATCH 1/3] Fixing an issue resulting in incorrect version information in an SDIST. --- .github/workflows/build-and-test.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/build-and-test.yml b/.github/workflows/build-and-test.yml index 69e237f83..8ab0b7218 100644 --- a/.github/workflows/build-and-test.yml +++ b/.github/workflows/build-and-test.yml @@ -163,6 +163,8 @@ jobs: os: [windows-latest, macos-latest] steps: - uses: actions/checkout@v3 + with: + - fetch-depth: 0 # Fetch complete history for accurate versioning - uses: ./.github/actions/setup_env with: From 94d261272b7cb3839b493d70156a3e2003c070f6 Mon Sep 17 00:00:00 2001 From: James Douglass Date: Tue, 28 May 2024 11:28:02 -0700 Subject: [PATCH 2/3] Elevating warnings to errors to catch sdist build issues. RE:#1581 --- .github/workflows/build-and-test.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/build-and-test.yml b/.github/workflows/build-and-test.yml index 8ab0b7218..1b8b5469f 100644 --- a/.github/workflows/build-and-test.yml +++ b/.github/workflows/build-and-test.yml @@ -178,7 +178,9 @@ jobs: # computer is guaranteed to have cython available at build # time. Thus, it is no longer necessary to distribute the # .cpp files in addition to the .pyx files. - python -m build --sdist + # + # Elevating any python warnings to errors to catch build issues ASAP. + python -W error -m build --sdist - name: Install from source distribution run : | From 2284cfbdb29f2254a390c51f79d8de776a251432 Mon Sep 17 00:00:00 2001 From: James Douglass Date: Tue, 28 May 2024 11:29:51 -0700 Subject: [PATCH 3/3] Correcting yaml syntax. RE:#1581 --- .github/workflows/build-and-test.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build-and-test.yml b/.github/workflows/build-and-test.yml index 1b8b5469f..e95d5bba5 100644 --- a/.github/workflows/build-and-test.yml +++ b/.github/workflows/build-and-test.yml @@ -164,7 +164,7 @@ jobs: steps: - uses: actions/checkout@v3 with: - - fetch-depth: 0 # Fetch complete history for accurate versioning + fetch-depth: 0 # Fetch complete history for accurate versioning - uses: ./.github/actions/setup_env with: