Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What is the difference between mrf_read.py and mrf_read_data.py? #66

Open
lucianpls opened this issue Jul 22, 2021 · 9 comments
Open

What is the difference between mrf_read.py and mrf_read_data.py? #66

lucianpls opened this issue Jul 22, 2021 · 9 comments

Comments

@lucianpls
Copy link
Member

No description provided.

@mcechini
Copy link
Contributor

Seems like the usage between the two is the major difference:

mrf_read_data.py --input [mrf_data_file] --output [output_file] (--offset INT --size INT) OR (--index [index_file] --tile INT)
mrf_read.py --input [mrf_file] --output [output_file] (--tilematrix INT --tilecol INT --tilerow INT) OR (--offset INT --size INT) OR (--tile INT)

@lucianpls
Copy link
Member Author

Doesn't sound like there is enough to keep both. Are you using any of these? The mrf_read_index is another one, you can do the same thing with "od".

@mike-mcgann
Copy link
Collaborator

I am using mrf_read.py

@lucianpls
Copy link
Member Author

What for? QC?

@mike-mcgann
Copy link
Collaborator

Yes, it is used in our automated end-to-end tests

@mcechini
Copy link
Contributor

We could consider consolidating if needed, but I find mrf_read.py's (--tilematrix INT --tilecol INT --tilerow INT) options to be very helpful.

@jtroberts
Copy link
Member

I don't see any strong reason to keep mrf_read_data.py

@lucianpls
Copy link
Member Author

That would be good. Maybe the mrf_read_index could be eliminated too, since it's not that useful? Or have it merged into mrf_read.py.

@jtroberts
Copy link
Member

I like the CSV output of mrf_read_index, but rarely every use it. I think it is helpful for debugging and understanding MRFs. It would be nice to merge it into mrf_read and then have only one tool to maintain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants