Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dates in nonstandard formats #6

Open
dp-rice opened this issue Apr 26, 2023 · 3 comments
Open

Dates in nonstandard formats #6

dp-rice opened this issue Apr 26, 2023 · 3 comments

Comments

@dp-rice
Copy link
Collaborator

dp-rice commented Apr 26, 2023

When parsing in metadata_samples.json, I've noticed some of the date are not parseable by datetime.date, e.g.:

  "ERR1224351": {
    "country": "Thailand",
    "date": "Summer 2013",
    "location": "Bankok",
    "reads": 95437411
  },

It would be nice if these were standardized in some way, either as valid dates or in some other way I can parse and connect to the prevalence data.

@jeffkaufman
Copy link
Member

Not sure the best way to represent these. I think the problem was that some were from June and some were from August, and I couldn't figure out from their metadata which were which. I could split the difference and say "2013-07", or just "2013"?

@dp-rice
Copy link
Collaborator Author

dp-rice commented Apr 26, 2023

Not sure if it's worth it, but you could introduce a "season" field if this happens often enough and make date a year.

@mikemc
Copy link
Member

mikemc commented Apr 26, 2023

Not sure if it's worth it, but you could introduce a "season" field if this happens often enough and make date a year.

Unless/until a 'season' field seems obviously useful, you might follow this suggestion of doing whatever you need to do to keep date as a well defined format, which here might be setting it to the year, and using a general-purpose 'notes' field to record that the sample is from June or August

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants