Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clicking on document while popup is not shown results in message being send #14

Open
mytlogos opened this issue Dec 9, 2018 · 0 comments
Open

Clicking on document while popup is not shown results in message being send #14

mytlogos opened this issue Dec 9, 2018 · 0 comments
Labels
bug Something isn't working

Comments

@mytlogos
Copy link
Owner

mytlogos commented Dec 9, 2018

Clicking anywhere on the document may result in a message being send to background script, which could lead to an error being thrown if user is not logged in.
The click listener should check if the popup is even shown and return if it isn't shown or no selectText function is set.
@mytlogos mytlogos added the bug Something isn't working label Dec 9, 2018
mytlogos added a commit that referenced this issue Feb 29, 2020
@mytlogos
Closes #14
b657f8e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mytlogos