Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aria-hidden warning on closing Dialog after initial render/mount #43901

Open
KishorJena opened this issue Sep 20, 2024 · 2 comments
Open

aria-hidden warning on closing Dialog after initial render/mount #43901

KishorJena opened this issue Sep 20, 2024 · 2 comments
Labels
accessibility a11y bug 🐛 Something doesn't work component: dialog This is the name of the generic UI component, not the React module! status: waiting for maintainer These issues haven't been looked at yet by a maintainer

Comments

@KishorJena
Copy link

KishorJena commented Sep 20, 2024

Steps to reproduce

Link to live example:

  1. stackblitz : https://stackblitz.com/run?file=Demo.js
  2. codesandbox : https://codesandbox.io/embed/m69y7p?module=/src/Demo.js
  3. mui doc: https://mui.com/material-ui/react-dialog (open console on official doc then open and close dialog)

All of these live code editors shows same error

Steps:

  1. Create a React application using Material-UI
  2. Implement a view button that opens a Dialog
  3. Load the page and open the Dialog for the first time
  4. Close the dialog.
  5. Observe the console for the aria-hidden error log
  6. Close and reopen the Dialog
  7. Note that the error does not appear on subsequent opens

Current behavior

On the first render after a page load/reload, opening the Dialog triggers an aria-hidden error in the console. Subsequent opens do not trigger the error.

Expected behavior

The Dialog should open without triggering any accessibility error related to aria-hidden attributes.

Context

This error was not occurring earlier version, its happening after upgrading mui to 6.0.2

Your environment

npx @mui/envinfo
  System:
    OS: Windows 11 10.0.22631
  Binaries:
    Node: 20.9.0 - C:\Program Files\nodejs\node.EXE
    npm: 10.3.0 - C:\Program Files\nodejs\npm.CMD
    pnpm: Not Found
  Browsers:
    Chrome: Not Found
    Edge: Chromium (127.0.2651.74)
  npmPackages:
    @emotion/react: ^11.13.3 => 11.13.3
    @emotion/styled: ^11.13.0 => 11.13.0
    @mui/base:  5.0.0-beta.58
    @mui/core-downloads-tracker:  6.0.2
    @mui/icons-material: ^6.0.2 => 6.0.2
    @mui/lab: ^6.0.0-beta.9 => 6.0.0-beta.9
    @mui/material: ^6.0.2 => 6.0.2
    @mui/material-nextjs: ^6.0.2 => 6.0.2
    @mui/private-theming:  6.0.2
    @mui/styled-engine:  6.0.2
    @mui/system:  6.0.2
    @mui/types:  7.2.16
    @mui/utils:  6.0.2
    @mui/x-data-grid: ^7.15.0 => 7.15.0
    @mui/x-internals:  7.15.0
    @types/react:  18.3.3
    react: ^18.3.1 => 18.3.1
    react-dom: ^18.3.1 => 18.3.1
    typescript:  5.4.5

Search keywords: aria hidden, dialog, version 6.0.2, v6,

Search keywords:

@KishorJena KishorJena added bug 🐛 Something doesn't work status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Sep 20, 2024
@github-actions github-actions bot added the component: data grid This is the name of the generic UI component, not the React module! label Sep 20, 2024
@michelengelen
Copy link
Member

To help us diagnose the issue efficiently, could you provide a stripped-down reproduction test case using the latest version? A live example would be fantastic! ✨

For your convenience, our documentation offers templates and guides on creating targeted examples: Support - Bug reproduction

Just a friendly reminder: clean, functional code with minimal dependencies is most helpful. Complex code can make it tougher to pinpoint the exact issue. Sometimes, simply going through the process of creating a minimal reproduction can even clarify the problem itself!

Thanks for your understanding! 🙇🏼

@michelengelen michelengelen added accessibility a11y status: waiting for author Issue with insufficient information and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Sep 20, 2024
@michelengelen michelengelen changed the title aria-hidden warning on Dialog closes for first time if cell of data grid trigger dialogue open [data grid] aria-hidden warning on Dialog closes for first time if cell of data grid trigger dialogue open Sep 20, 2024
@KishorJena KishorJena changed the title [data grid] aria-hidden warning on Dialog closes for first time if cell of data grid trigger dialogue open [data grid] aria-hidden warning on closing Dialog after initial render/mount Sep 22, 2024
@KishorJena KishorJena changed the title [data grid] aria-hidden warning on closing Dialog after initial render/mount aria-hidden warning on closing Dialog after initial render/mount Sep 22, 2024
@KishorJena
Copy link
Author

To help us diagnose the issue efficiently, could you provide a stripped-down reproduction test case using the latest version? A live example would be fantastic! ✨

For your convenience, our documentation offers templates and guides on creating targeted examples: Support - Bug reproduction

Just a friendly reminder: clean, functional code with minimal dependencies is most helpful. Complex code can make it tougher to pinpoint the exact issue. Sometimes, simply going through the process of creating a minimal reproduction can even clarify the problem itself!

Thanks for your understanding! 🙇🏼

Thank you for quick response.
As you suggested to add live examples so I have added links to live examples
and
I found that it not specific to datagrid only so i have edited the title and description of issue.
I believe its related to MUI v6.0.2.

@github-actions github-actions bot added status: waiting for maintainer These issues haven't been looked at yet by a maintainer and removed status: waiting for author Issue with insufficient information labels Sep 22, 2024
@MBilalShafi MBilalShafi transferred this issue from mui/mui-x Sep 27, 2024
@MBilalShafi MBilalShafi added component: dialog This is the name of the generic UI component, not the React module! and removed component: data grid This is the name of the generic UI component, not the React module! labels Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility a11y bug 🐛 Something doesn't work component: dialog This is the name of the generic UI component, not the React module! status: waiting for maintainer These issues haven't been looked at yet by a maintainer
Projects
None yet
Development

No branches or pull requests

3 participants